Skip to content

Allow user to configure whether workers are daemon.#2739

Merged
mrocklin merged 2 commits intodask:masterfrom
calebho:no-daemon
May 31, 2019
Merged

Allow user to configure whether workers are daemon.#2739
mrocklin merged 2 commits intodask:masterfrom
calebho:no-daemon

Conversation

@calebho
Copy link
Copy Markdown
Contributor

@calebho calebho commented May 31, 2019

Closes #2718

@mrocklin
Copy link
Copy Markdown
Member

mrocklin commented May 31, 2019

Thanks @calebho . This looks great. You can safely ignore the windows test failures. They're being resolved elsewhere.

One final thing, can I ask you to add the default value into this file: https://github.com/dask/distributed/blob/master/distributed/distributed.yaml ?

@mrocklin
Copy link
Copy Markdown
Member

mrocklin commented May 31, 2019

Thanks @calebho . Merging.

Also, I notice that this is your first code contribution to this repository. Welcome!

@mrocklin mrocklin merged commit a16b8ff into dask:master May 31, 2019
@calebho calebho deleted the no-daemon branch June 1, 2019 00:14
muammar added a commit to muammar/distributed that referenced this pull request Jun 12, 2019
@muammar
Merge remote-tracking branch 'upstream/master'
bd57526 
* upstream/master: (58 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
muammar added a commit to muammar/distributed that referenced this pull request Jul 18, 2019
@muammar
Merge remote-tracking branch 'upstream/master'
ee6df1a 
* upstream/master: (43 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Non-daemonic workers

2 participants

@calebho @mrocklin