Closed
Conversation
Contributor
|
Just echoing discord conversations:
|
Contributor
|
@jlongtine fyi you can just rebase this on main and get rid of my commit here: 879fdda I fixed this in a separate better way here, which was merged. |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
879fdda to
8f13cf4
Compare
added 3 commits
August 16, 2023 09:44
Signed-off-by: Joel Longtine <joel@dagger.io>
Signed-off-by: Joel Longtine <joel@dagger.io>
Signed-off-by: Joel Longtine <joel@dagger.io>
4c39f22 to
697ceee
Compare
Signed-off-by: Joel Longtine <joel@longtine.io>
02fa22c to
f0c9923
Compare
gerhard
added a commit
that referenced
this pull request
Aug 17, 2023
* Re-enable manual trigger for Elixir SDK Signed-off-by: Gerhard Lazu <gerhard@dagger.io> * Run Engine tests in dev Engine (on top of stable Engine) So that we can find potential failures earlier, as we've learned from v0.8.0 & v0.8.3 releases. Allow PRs to use both Dagger runners & paid GitHub runners (same size). It's OK if these fail for now - `continue-on-error` - since we seem to have a configuration issue on the self-hosted runners themselves (they are attempting to use the same Engine). We can follow-up with a fix. By the way, if we like this change, we can roll it out to other jobs - supersedes #5359 Stop uploading journal.log. Since we are reusing workflows, we cannot easily determine the journal log file name (the same one gets overwritten by different workflows). If we use inputs.mage-targets to distinguish, this fails since it contains ':', an unsupported character by the upload-artifact action. We could do this better (e.g. by requiring another input, by handling this in code, etc.), but I am unsure what is the current value of journal.log when we use Dagger Cloud. Removing it for now, let's see if others miss it. Signed-off-by: Gerhard Lazu <gerhard@dagger.io> --------- Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Member
|
I think we are actually using Dagger runner in our CI, is this PR still useful? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a test