core: improve image publish/export format compatibility.#5365
Merged
sipsma merged 1 commit intodagger:mainfrom Jun 24, 2023
Merged
core: improve image publish/export format compatibility.#5365sipsma merged 1 commit intodagger:mainfrom
sipsma merged 1 commit intodagger:mainfrom
Conversation
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
jlongtine
approved these changes
Jun 24, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went down a bit of a rabbit hole after looking into this problem related to running dagger tests w/ magicache.
That rabbit hole is an extension of previous rabbit holes when similar issues were hit w/ Airbyte and when trying to do an upgrade the other week.
The important takeaways from the most recent investigation:
vnd.docker.image.rootfs.diff.tar.zstdhas never been a thing ever outside of buildkit, afaict it's the only place that string even exists? I now think the fact that buildkit ever exports using those might actually just be a bug rather than a feature. The only zstd media type that really exists in the ecosystem is the oci one.docker loading them; it just checks the archive headers directly to figure out whether it's a support compression type.So given that the conclusions were:
I updated that logic and also added an integ test that verifies the expected
docker loadcompatibility behavior going back to 20.x releases (not sure we need to care about older). This compat is important as it's explicitly relied on in our docs.