Run Engine tests in dev Engine (on top of stable Engine)#5652
Merged
gerhard merged 2 commits intodagger:mainfrom Aug 17, 2023
gerhard:test-engine-in-dev-engine
Merged
Run Engine tests in dev Engine (on top of stable Engine)#5652gerhard merged 2 commits intodagger:mainfrom gerhard:test-engine-in-dev-engine
gerhard merged 2 commits intodagger:mainfrom
gerhard:test-engine-in-dev-engine
Conversation
Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
So that we can find potential failures earlier, as we've learned from v0.8.0 & v0.8.3 releases. Allow PRs to use both Dagger runners & paid GitHub runners (same size). It's OK if these fail for now - `continue-on-error` - since we seem to have a configuration issue on the self-hosted runners themselves (they are attempting to use the same Engine). We can follow-up with a fix. By the way, if we like this change, we can roll it out to other jobs - supersedes #5359 Stop uploading journal.log. Since we are reusing workflows, we cannot easily determine the journal log file name (the same one gets overwritten by different workflows). If we use inputs.mage-targets to distinguish, this fails since it contains ':', an unsupported character by the upload-artifact action. We could do this better (e.g. by requiring another input, by handling this in code, etc.), but I am unsure what is the current value of journal.log when we use Dagger Cloud. Removing it for now, let's see if others miss it. Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Contributor
Author
|
Engine tests ran successfully in a dev Engine: https://github.com/dagger/dagger/actions/runs/5893199071/job/15984222717?pr=5652#step:4:517 
The |
sipsma
approved these changes
Aug 17, 2023
Contributor
sipsma
left a comment
There was a problem hiding this comment.
Looks great, thanks! Gonna save us all a lot of pain!
Contributor
Author
|
Another issue that this PR is going to help address: https://github.com/dagger/dagger/actions/runs/5893416043/job/15984907482#step:5:182
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can find potential failures earlier, as we've learned from
v0.8.0&v0.8.3releases. cc @sipsma @vitoAllow PRs to use both Dagger runners & paid GitHub runners (same size). It's OK if these fail for now -
continue-on-error- since we seem to have a configuration issue on the self-hosted runners themselves (they are attempting to use the same Engine). We can follow-up with a fix. cc @jlongtineBy the way, if we like this change, we can roll it out to other jobs - supersedes #5359
Stop uploading
journal.log. Since we are reusing workflows, we cannot easily determine the journal log file name (the same one gets overwritten by different workflows). If we use inputs.mage-targets to distinguish, this fails since it contains:, an unsupported character by theupload-artifactaction. We could do this better (e.g. by requiring another input, by handling this in code, etc.), but I am unsure what is the current value of journal.log when we use Dagger Cloud. Removing it for now, let's see if others miss it.