[CHORE] (cu29_runtime) improve error handling#708
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c4395f658
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+132
to
+136
| // clone the last finished output (if any) as the visible result for this polling round | ||
| let buffered_output = self.output.lock().unwrap(); | ||
| let buffered_output = self | ||
| .output | ||
| .lock() | ||
| .map_err(|_| CuError::from("Async task output mutex poisoned"))?; |
There was a problem hiding this comment.
Reset async state when output lock is poisoned
If the output mutex is poisoned, this ? returns early with an error after state.processing was already set to true earlier in process. That leaves the async state permanently in “processing” without any background task running, so every later poll will return Ok(()) and never reschedule work. This only happens when the output mutex is poisoned (e.g., a panic in a previous background run), but in that case the task will deadlock instead of surfacing the error. Consider clearing processing and recording last_error when this lock fails.
Useful? React with 👍 / 👎.
…tput mutex is poisoned in CuAsyncTask::process
gbin
approved these changes
Jan 22, 2026
gbin
pushed a commit
that referenced
this pull request
Jan 22, 2026
* (cu29_runtime) improve error handling * cleared the async processing state and recorded the error when the output mutex is poisoned in CuAsyncTask::process * fmt
gbin
added a commit
that referenced
this pull request
Jan 23, 2026
* Iceorix2 ported as a bridge. * ronfmt lint * simplify * [CHORE] Removed unused `cu29::prelude::*` imports causing warnings in generated workspace templates: (#711) - `templates/cu_full/components/bridges/cu_example_shared_bridge/src/messages.rs` - `templates/cu_full/apps/cu_example_app/src/messages.rs` You can regenerate the workspace and rerun `cargo build` to confirm the warnings are gone. * Resolve cu29_export merge conflict * (cu29_helpers) improve error handling (#703) * (cu29_value) improve error handling (#702) * (cu29_log) improve error handling (#705) * (cu29_soa_derive) improve error handling (#706) * Upgraded the glam dependency to 0.31 in the two crates that declare it, and verified both dependent crates still check cleanly. (#713) Changes: - Updated glam version in `components/libs/cu_transform/Cargo.toml`. - Updated glam version in `components/payloads/cu_spatial_payloads/Cargo.toml`. Checks run: - `cargo +stable check -p cu-transform -p cu-spatial-payloads` Next steps (optional): 1. Run `cargo +stable check --workspace` if you want broader coverage. 2. Run `cargo +stable nextest run -p cu-transform -p cu-spatial-payloads` if you want tests as well. * Updated nix dependency versions to `0.31` in the two crates that directly use it and ran cargo check on those crates. (#714) Changes: - `components/sources/cu_v4l/Cargo.toml` - `examples/cu_msp_bridge_loopback/Cargo.toml` Checks run: - `cargo +stable check -p cu-v4l -p cu-msp-bridge-loopback` If you want, I can also run the broader CI-aligned checks (`just std-ci`) or `cargo +stable nextest run --workspace --all-targets`. * [CHORE] update cudarc deps to 0.19 (#715) * (cu29_log_derive) improve error handling (#707) * [CHORE] (cu29_runtime) improve error handling (#708) * (cu29_runtime) improve error handling * cleared the async processing state and recorded the error when the output mutex is poisoned in CuAsyncTask::process * fmt * [CHORE] (cu29_unifiedlog) improve error handling (#704) * (cu29_unifiedlog) improve error handling * simplify --------- Co-authored-by: Yang Zhou <yangzhou.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.