[release-0.0.99.5] Prepare stable branch (part 2)#1740
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Summary of ChangesHello @debarshiray, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is a crucial step in preparing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
This is meant to make the project more searchable on the Internet. More and more people have been pointing out that "toolbox" is terribly difficult to search for, and it's impossible to find any decent Internet real estate by that name. containers#1399 containers#1740 (backported from commit c3403da)
containers#1468 containers#1740 (cherry picked from commit 9ea8967)
There was a problem hiding this comment.
Code Review
This pull request prepares the release-0.0.99.5 stable branch. The changes include updating the Zuul CI configuration for the new release, removing a significant number of container image definition files, fixing a system test to be more robust, and applying a bug fix to the main toolbox script. The changes are logical for a release preparation. I've found a few minor typos in the CI configuration descriptions that should be fixed.
7f745b6 to
e7043ea
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Build failed. ✔️ unit-test SUCCESS in 1m 38s |
|
Build failed. ✔️ unit-test SUCCESS in 1m 39s |
Fedora 38 reached End of Life on 21st May 2024: https://docs.fedoraproject.org/en-US/releases/eol/ containers#1527 containers#1740 (cherry picked from commit b684b19)
|
Build succeeded. ✔️ unit-test SUCCESS in 1m 48s |
The paths to bats-assert and bats-support are broken, if bats(1) is invoked from any other location than the parent directory of the 'tests' directory. eg., Podman's downstream Fedora CI invokes the tests as: $ cd /path/to/toolbox/test/system $ bats . ... and it led to [1]: 1..306 # test suite: Set up # Missing dependencies # Forgot to run 'git submodule init' and 'git submodule update' ? # test suite: Tear down not ok 1 setup_suite # (from function `setup_suite' in test file ./setup_suite.bash, line 33) # `return 1' failed # bats warning: Executed 1 instead of expected 306 tests Fallout from 2c09606 [1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968 containers#1448 containers#1740 (cherry picked from commit 6838e93)
The working directory from which bats(1) is invoked might not be part of
the Toolbx container. eg., Podman's downstream Fedora CI invokes the
tests as:
$ cd /path/to/toolbox/test/system
$ bats .
... and it led to [1]:
not ok 110 run: Smoke test with true(1)
# (from function `assert_output' in file
./libs/bats-assert/src/assert.bash, line 255,
# in test file ./104-run.bats, line 38)
# `assert_output ""' failed
#
# -- output differs --
# expected (0 lines):
#
# actual (3 lines):
# Error: crun: chdir to `/usr/share/toolbox/test/system`: No such
file or directory: OCI runtime attempted to invoke a command that
was not found
# Error: directory /usr/share/toolbox/test/system not found in
container fedora-toolbox-41
# Using /home/testuser instead.
# --
#
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968
containers#1457
containers#1740
(cherry picked from commit 9d3ae61)
399a49d to
a72f1da
Compare
Fedora 38 reached End of Life on 21st May 2024: https://docs.fedoraproject.org/en-US/releases/eol/ containers#1527 containers#1740 (cherry picked from commit b684b19)
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526 containers#1740 (backported from commit 67d4002)
containers#1550 containers#1740 (cherry picked from commit 679bf87)
|
Build failed. ✔️ unit-test SUCCESS in 1m 45s |
|
Build failed. ✔️ unit-test SUCCESS in 1m 37s |
c0fb8f3
into
containers:release-0.0.99.5
This is meant to make the project more searchable on the Internet. More and more people have been pointing out that "toolbox" is terribly difficult to search for, and it's impossible to find any decent Internet real estate by that name. containers#1399 containers#1740 containers#1744 (backported from commit c3403da) (backported from commit e7043ea)
containers#1468 containers#1740 (cherry picked from commit 9ea8967) (cherry picked from commit ec3553b)
containers#1468 containers#1740 containers#1750 (cherry picked from commit 9ea8967) (cherry picked from commit ec3553b)
containers#1468 containers#1740 containers#1750 (cherry picked from commit 9ea8967) (cherry picked from commit ec3553b)
The working directory from which bats(1) is invoked might not be part of
the Toolbx container. eg., Podman's downstream Fedora CI invokes the
tests as:
$ cd /path/to/toolbox/test/system
$ bats .
... and it led to [1]:
not ok 110 run: Smoke test with true(1)
# (from function `assert_output' in file
./libs/bats-assert/src/assert.bash, line 255,
# in test file ./104-run.bats, line 38)
# `assert_output ""' failed
#
# -- output differs --
# expected (0 lines):
#
# actual (3 lines):
# Error: crun: chdir to `/usr/share/toolbox/test/system`: No such
file or directory: OCI runtime attempted to invoke a command that
was not found
# Error: directory /usr/share/toolbox/test/system not found in
container fedora-toolbox-41
# Using /home/testuser instead.
# --
#
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968
containers#1457
containers#1740
containers#1750
(cherry picked from commit 9d3ae61)
(backported from commit c0fb8f3)
... for CVE-2025-65637 or GHSA-4f99-4q7p-p3gh.
https://github.com/containers/toolbox/security/dependabot/26