test/system: Consolidate teardown() to remove both containers & images#1526
Conversation
|
Build failed. ✔️ unit-test SUCCESS in 6m 17s |
|
This is odd: no space left on device |
368f910 to
bb08f47
Compare
|
recheck |
Earlier this was happening only on Fedora Rawhide, but now it's happening on Fedora 40 too. |
|
Build failed. ✔️ unit-test SUCCESS in 5m 57s |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. containers#1526
bb08f47 to
475c693
Compare
|
Build failed. ✔️ unit-test SUCCESS in 6m 55s |
|
recheck |
|
Build failed. ✔️ unit-test SUCCESS in 5m 58s |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526
475c693 to
aa46462
Compare
|
Build failed. ✔️ unit-test SUCCESS in 6m 49s |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526
aa46462 to
f5ba81f
Compare
|
Build failed. ✔️ unit-test SUCCESS in 6m 45s |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526
f5ba81f to
4264173
Compare
|
Build failed. ✔️ unit-test SUCCESS in 6m 52s |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526
4264173 to
67d4002
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 37s |
|
Seems like Software Factory somehow fixed itself. Yay! |
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526 containers#1740 (backported from commit 67d4002)
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526 containers#1741 (backported from commits 67d4002 and 55c0e63)
It's far more consistent and understandable if all tests start with a clean state without any containers or images present. Otherwise, the subtle side-effects of having some image left behind from a previous test can lead to surprises, and there's no need to spend time wondering whether some tests should only clean up the containers or both containers and images. This additional work of cleaning up the images for all tests makes it necessary to increase the timeout for all Fedora nodes to prevent the CI from timing out. containers#1526 containers#1741 containers#1750 (backported from commits 67d4002 and 55c0e63) (backported from commit 23b4a34)
It's far more consistent and understandable if all tests start with a
clean state without any containers or images present. Otherwise, the
subtle side-effects of having some image left behind from a previous
test can lead to surprises, and there's no need to spend time wondering
whether some tests should only clean up the containers or both
containers and images.