test/system: Unbreak Podman's downstream Fedora CI#1448
Merged
debarshiray merged 1 commit intocontainers:mainfrom Feb 13, 2024
Merged
test/system: Unbreak Podman's downstream Fedora CI#1448debarshiray merged 1 commit intocontainers:mainfrom
debarshiray merged 1 commit intocontainers:mainfrom
Conversation
The paths to bats-assert and bats-support are broken, if bats(1) is invoked from any other location than the parent directory of the 'tests' directory. eg., Podman's downstream Fedora CI invokes the tests as: $ cd /path/to/toolbox/test/system $ bats . ... and it led to [1]: 1..306 # test suite: Set up # Missing dependencies # Forgot to run 'git submodule init' and 'git submodule update' ? # test suite: Tear down not ok 1 setup_suite # (from function `setup_suite' in test file ./setup_suite.bash, line 33) # `return 1' failed # bats warning: Executed 1 instead of expected 306 tests Fallout from 2c09606 [1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968 containers#1448
8dd9538 to
6838e93
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 4m 43s |
debarshiray
added a commit
to debarshiray/toolbox
that referenced
this pull request
Jan 26, 2026
The paths to bats-assert and bats-support are broken, if bats(1) is invoked from any other location than the parent directory of the 'tests' directory. eg., Podman's downstream Fedora CI invokes the tests as: $ cd /path/to/toolbox/test/system $ bats . ... and it led to [1]: 1..306 # test suite: Set up # Missing dependencies # Forgot to run 'git submodule init' and 'git submodule update' ? # test suite: Tear down not ok 1 setup_suite # (from function `setup_suite' in test file ./setup_suite.bash, line 33) # `return 1' failed # bats warning: Executed 1 instead of expected 306 tests Fallout from 2c09606 [1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968 containers#1448 containers#1740 (cherry picked from commit 6838e93)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paths to
bats-assertandbats-supportare broken, ifbats(1)is invoked from any other location than the parent directory of thetestsdirectory. eg., Podman's downstream Fedora CI invokes the tests as:... and it led to [1]:
Fallout from 2c09606
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2263968