stream: Fix default data won't be received issue#208
Merged
lifupan merged 2 commits intocontainerd:masterfrom Aug 18, 2023
Merged
stream: Fix default data won't be received issue#208lifupan merged 2 commits intocontainerd:masterfrom
lifupan merged 2 commits intocontainerd:masterfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 24.42% 24.35% -0.07%
==========================================
Files 16 16
Lines 2645 2652 +7
==========================================
Hits 646 646
- Misses 1999 2006 +7
☔ View full report in Codecov by Sentry. |
Collaborator
|
would it be worth adding a message to the example that validates this? Sounds like it is pretty easy to replicate by passing 0's here ttrpc-rust/example/async-stream-client.rs Lines 124 to 125 in 555c412 |
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Aug 10, 2023
And verify containerd#208 Signed-off-by: Tim Zhang <tim@hyper.sh>
Member
Author
|
@jsturtevant Good suggestion, I've just finished it and please help to review it again, thanks |
Protobuf encodes default values, e.g., 0 for number, "" for string, as empty payload and we wouldn't send empty payload to a receiver. This commit change the method of empty message detecting. Fixes containerd#169 Fixes containerd#207 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Aug 10, 2023
Add test for issues: containerd#169, containerd#207 Signed-off-by: Tim Zhang <tim@hyper.sh>
5884e9a to
2678850
Compare
jsturtevant
reviewed
Aug 10, 2023
jsturtevant
reviewed
Aug 10, 2023
studychao
reviewed
Aug 13, 2023
example/async-stream-client.rs
Outdated
|
|
||
| #[cfg(unix)] | ||
| async fn divide_stream(cli: streaming_ttrpc::StreamingClient) { | ||
| let mut stream = cli |
There was a problem hiding this comment.
nit: Could we create a test case to test the default value specifically instead of messing it into divide_stream?
Member
Author
There was a problem hiding this comment.
A new case was added instead of modifying one of the exists.
Add test for issues: containerd#169, containerd#207. Signed-off-by: Tim Zhang <tim@hyper.sh>
2678850 to
e16aa7b
Compare
studychao
approved these changes
Aug 14, 2023
jsturtevant
approved these changes
Aug 15, 2023
lifupan
approved these changes
Aug 18, 2023
Tim-Zhang
added a commit
to Tim-Zhang/ttrpc-rust
that referenced
this pull request
Aug 22, 2023
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208 Signed-off-by: Tim Zhang <tim@hyper.sh>
Merged
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
Add test for issues: containerd#169, containerd#207. Signed-off-by: Tim Zhang <tim@hyper.sh>
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
…ult-data stream: Fix default data won't be received issue
KarstenB
pushed a commit
to KarstenB/ttrpc-rust
that referenced
this pull request
May 1, 2025
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208 Signed-off-by: Tim Zhang <tim@hyper.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf encodes default values, e.g., 0 for number, "" for string, as empty payload and we wouldn't send empty payload to a receiver.
This commit change the method of empty message detecting.
Fixes #169
Fixes #207