Skip to content

stream: public stream related types#196

Merged
lifupan merged 1 commit intocontainerd:masterfrom
wllenyj:pub-stream
Jul 6, 2023
Merged

stream: public stream related types#196
lifupan merged 1 commit intocontainerd:masterfrom
wllenyj:pub-stream

Conversation

@wllenyj
Copy link
Copy Markdown
Collaborator

@wllenyj wllenyj commented Jun 22, 2023

Fixes: #195

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e94bb9f) 24.47% compared to head (ae5bfac) 24.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   24.47%   24.47%           
=======================================
  Files          17       17           
  Lines        2521     2521           
=======================================
  Hits          617      617           
  Misses       1904     1904           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mod unix_incoming;

pub use self::stream::{
ClientStream, ClientStreamReceiver, ClientStreamSender, Kind, ServerStream,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind is dropped here. Is that intentional?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my fault, fixed.

Fixes: containerd#195

Signed-off-by: wanglei01 <wllenyj@gmail.com>
Copy link
Copy Markdown
Member

@Tim-Zhang Tim-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wllenyj

@lifupan lifupan merged commit f00994f into containerd:master Jul 6, 2023
Tim-Zhang added a commit to Tim-Zhang/ttrpc-rust that referenced this pull request Aug 22, 2023
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang mentioned this pull request Aug 22, 2023
KarstenB pushed a commit to KarstenB/ttrpc-rust that referenced this pull request May 1, 2025
stream: public stream related types
KarstenB pushed a commit to KarstenB/ttrpc-rust that referenced this pull request May 1, 2025
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208

Signed-off-by: Tim Zhang <tim@hyper.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientStream.split exposes private types

4 participants