Skip to content

[master] Fix the bug caused by oversized packets#203

Merged
teawater merged 5 commits intocontainerd:masterfrom
Tim-Zhang:fix-over-size-limit-master
Jul 19, 2023
Merged

[master] Fix the bug caused by oversized packets#203
teawater merged 5 commits intocontainerd:masterfrom
Tim-Zhang:fix-over-size-limit-master

Conversation

@Tim-Zhang
Copy link
Copy Markdown
Member

Fixes: #198

Refactor by using extracting method.

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang requested review from lifupan and wllenyj July 12, 2023 11:06
@Tim-Zhang Tim-Zhang force-pushed the fix-over-size-limit-master branch from 5342f91 to bf0b176 Compare July 12, 2023 11:42
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 20.00% and project coverage change: -0.01 ⚠️

Comparison is base (cc6b187) 24.42% compared to head (3ef0e4e) 24.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   24.42%   24.42%   -0.01%     
==========================================
  Files          17       16       -1     
  Lines        2526     2645     +119     
==========================================
+ Hits          617      646      +29     
- Misses       1909     1999      +90     
Impacted Files Coverage Δ
src/asynchronous/client.rs 0.00% <0.00%> (ø)
src/asynchronous/connection.rs 0.00% <ø> (ø)
src/asynchronous/server.rs 0.00% <0.00%> (ø)
src/asynchronous/stream.rs 0.00% <0.00%> (ø)
src/common.rs 35.57% <ø> (ø)
src/error.rs 38.46% <0.00%> (-17.10%) ⬇️
src/sync/channel.rs 0.00% <0.00%> (ø)
src/sync/client.rs 0.00% <0.00%> (ø)
src/sync/server.rs 0.00% <0.00%> (ø)
src/sync/utils.rs 0.00% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tim-Zhang Tim-Zhang force-pushed the fix-over-size-limit-master branch 2 times, most recently from b81602a to ec9f5cc Compare July 12, 2023 11:58
Fixes: containerd#198

Signed-off-by: Tim Zhang <tim@hyper.sh>
server: check before send to client
client: check before send to server

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang force-pushed the fix-over-size-limit-master branch from ec9f5cc to 5d8be72 Compare July 12, 2023 13:48
@Tim-Zhang Tim-Zhang force-pushed the fix-over-size-limit-master branch 3 times, most recently from 258cba4 to 6056868 Compare July 13, 2023 12:33
Fix containerd#198

Signed-off-by: Tim Zhang <tim@hyper.sh>
server: check before sending to client
client: check before sending to server

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang force-pushed the fix-over-size-limit-master branch from 6056868 to 3ef0e4e Compare July 17, 2023 06:24
@teawater teawater merged commit 555c412 into containerd:master Jul 19, 2023
@Tim-Zhang Tim-Zhang deleted the fix-over-size-limit-master branch July 19, 2023 06:16
Tim-Zhang added a commit to Tim-Zhang/ttrpc-rust that referenced this pull request Aug 22, 2023
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208

Signed-off-by: Tim Zhang <tim@hyper.sh>
@Tim-Zhang Tim-Zhang mentioned this pull request Aug 22, 2023
KarstenB pushed a commit to KarstenB/ttrpc-rust that referenced this pull request May 1, 2025
…master

[master] Fix the bug caused by oversized packets
KarstenB pushed a commit to KarstenB/ttrpc-rust that referenced this pull request May 1, 2025
Cut the release for containerd#196, containerd#197, containerd#200, containerd#203, containerd#208

Signed-off-by: Tim Zhang <tim@hyper.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The connection stream will be out of order while a packet received whose size exceeds 4Mb

3 participants