Skip to content

[release/1.4] Fix incorrect UA used for registry authentication#5761

Merged
dmcgowan merged 1 commit intocontainerd:release/1.4from
thaJeztah:1.4_backport_fix_auth_ua
Jul 20, 2021
Merged

[release/1.4] Fix incorrect UA used for registry authentication#5761
dmcgowan merged 1 commit intocontainerd:release/1.4from
thaJeztah:1.4_backport_fix_auth_ua

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

This is the equivalent of 50ad4b9 (#5533), but modified for the release/1.4 branch. From the original commit:

Previously, containerd uses Go's default UA "Go-http-client/1.1" while authenticating with registry.
This commit changes it to the pattern like "containerd/v1.5.2" which is used for all other requests.

Fixes #5532 for 1.4.x

This is the equivalent of 50ad4b9, but modified
for the release/1.4 branch. From the original commit:

> Previously, containerd uses Go's default UA "Go-http-client/1.1" while authenticating with registry.
> This commit changes it to the pattern like "containerd/v1.5.2" which is used for all other requests.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jul 20, 2021

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member Author

Windows failure doesn't look related

Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit e4418db into containerd:release/1.4 Jul 20, 2021
@thaJeztah thaJeztah deleted the 1.4_backport_fix_auth_ua branch July 20, 2021 17:15
breakings added a commit to breakings/packages that referenced this pull request Aug 8, 2021
The ninth patch release for containerd 1.4 updates runc to 1.0.1 and contains
other minor updates.

### Notable Updates

- **Update runc binary to 1.0.1** [#5751](containerd/containerd#5751)
- **Update pull authorization logic on redirect** [#5504](containerd/containerd#5504)
- **Fix user agent used for fetching registry authentication tokens** [#5761](containerd/containerd#5761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants