Skip to content

Fix incorrect UA used for registry authentication#5533

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
Einsfier:fix-auth-ua
May 26, 2021
Merged

Fix incorrect UA used for registry authentication#5533
dmcgowan merged 1 commit intocontainerd:masterfrom
Einsfier:fix-auth-ua

Conversation

@Einsfier
Copy link
Copy Markdown
Contributor

@Einsfier Einsfier commented May 25, 2021 •
edited
Loading

Previously, containerd uses Go's default UA "Go-http-client/1.1" while authenticating with registry.
This commit changes it to the pattern like "containerd/v1.5.2" which is used for all other requests.

Fixes #5532

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented May 25, 2021

Hi @povsister. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 25, 2021

Build succeeded.

estesp
estesp approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samuelkarp
samuelkarp approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but we usually request that the Signed-off-by line have your name rather than your GitHub username. Can you update your commit to use your name there?

@estesp estesp added status/more-info-needed Awaiting contributor information and removed needs-ok-to-test labels May 25, 2021
@Einsfier
Fix incorrect UA used for registry authentication
50ad4b9 
Previously, containerd uses Go's default UA "Go-http-client/1.1" while authenticating with registry.
This commit changes it to the pattern like "containerd/v1.5.2" which is used for all other requests.

Signed-off-by: Ethan Chen <pov@mahou-shoujo.moe>
@Einsfier
Copy link
Copy Markdown
Contributor Author

Einsfier commented May 26, 2021

Can you update your commit to use your name there?

Okay, updated.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented May 26, 2021

Build succeeded.

@fuweid fuweid removed the status/more-info-needed Awaiting contributor information label May 26, 2021
@dmcgowan dmcgowan merged commit f0d2f89 into containerd:master May 26, 2021
@Einsfier Einsfier mentioned this pull request Jun 11, 2021
Merged
@AkihiroSuda AkihiroSuda added cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch and removed cherry-pick/1.5.x labels Jun 11, 2021
estesp added a commit that referenced this pull request Jun 11, 2021
@estesp
Merge pull request #5598 from povsister/release/1.5
116b2e0 
[release/1.5] cherry-pick #5533: Fix incorrect UA used for registry authentication
@thaJeztah thaJeztah mentioned this pull request Jul 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.5.x PR commits are cherry-picked into release/1.5 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Registry: incorrect UA used for registry authentication

7 participants

@Einsfier @k8s-ci-robot @dmcgowan @samuelkarp @estesp @fuweid @AkihiroSuda