Registry: incorrect UA used for registry authentication #5532
Description
Description
containerd is using Go's default user agent Go-http-client/1.1 for registry authentication related requests while other requests are using the correct user agent like containerd/v1.5.2.
Steps to reproduce the issue:
ctr images pull -u user:password myregistry.private/image:test- Read request logs from
myregistry.private
Describe the results you received:
172.16.0.1 - - [25/May/2021:07:34:40 +0000] "HEAD /v2/itom-registry/manifests/PR-17 HTTP/1.1" 401 156 "" "containerd/v1.5.2"
172.16.0.1 - - [25/May/2021:07:34:40 +0000] "POST /auth/token HTTP/1.1" 405 0 "" "Go-http-client/1.1"
172.16.0.1 - - [25/May/2021:07:34:40 +0000] "GET /auth/token?scope=repository%3Aimage%3Apull&scope=repository%3Aimage%3Apull%2Cpush&service=my-token-service HTTP/1.1" 200 301 "" "Go-http-client/1.1"
172.16.0.1 - - [25/May/2021:07:34:41 +0000] "HEAD /v2/image/blobs/sha256:6df53f70f10b44aaeefe02682c4089d777d073d9bc457a6ff5f80610b45ba291 HTTP/1.1" 404 157 "" "containerd/v1.5.2"
Describe the results you expected:
containerd should always use UA like containerd/v1.5.2 for outgoing registry requests.
What version of containerd are you using:
$ containerd --version
containerd github.com/containerd/containerd v1.5.2 36cc874494a56a253cd181a1a685b44b58a2e34a
Any other relevant information (runC version, CRI configuration, OS/Kernel version, etc.):
Not needed