feat(proto)!: replace PubKey in abci.ValidatorUpdate with PubKeyType and PubKeyBytes#2843
Merged
feat(proto)!: replace PubKey in abci.ValidatorUpdate with PubKeyType and PubKeyBytes#2843
PubKey in abci.ValidatorUpdate with PubKeyType and PubKeyBytes#2843Conversation
4 tasks
Collaborator
|
The spec needs to be updated. For instance, here https://github.com/cometbft/cometbft/blob/main/spec/abci/abci%2B%2B_methods.md#validatorupdate |
sergio-mena
reviewed
Apr 18, 2024
andynog
approved these changes
Apr 18, 2024
Collaborator
andynog
left a comment
There was a problem hiding this comment.
lgtm, I don't have deep expertise in the pubkey usage but made a couple of comments on things that jump into my head while understanding the logic a bit better. Feel free to disregard if it doesn't make sense.
sergio-mena
reviewed
Apr 19, 2024
sergio-mena
reviewed
Apr 19, 2024
sergio-mena
reviewed
Apr 19, 2024
sergio-mena
reviewed
Apr 19, 2024
sergio-mena
reviewed
Apr 19, 2024
cason
approved these changes
Apr 19, 2024
cason
left a comment
There was a problem hiding this comment.
Not a part of code I know, but no restrictions.
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…Type` and `PubKeyBytes` (#2843) This PR deprecates `PubKey` in `abci.ValidatorUpdate` and adds two new fields: - string `PubKeyType` - bytes `PubKeyBytes` Co-authored by: @tac0turtle --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com> Co-authored-by: Andy Nogueira <me@andynogueira.dev> (cherry picked from commit 71cd087) # Conflicts: # abci/example/kvstore/kvstore.go
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 24, 2024
…Type` and `PubKeyBytes` (backport #2843) (#2879) This PR deprecates `PubKey` in `abci.ValidatorUpdate` and adds two new fields: - string `PubKeyType` - bytes `PubKeyBytes` Co-authored by: @tac0turtle --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2843 done by [Mergify](https://mergify.com). --------- Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878 Follow-up to #2843 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878 Follow-up to #2843 <!-- Please add a reference to the issue that this PR addresses and indicate which files are most critical to review. If it fully addresses a particular issue, please include "Closes #XXX" (where "XXX" is the issue number). If this PR is non-trivial/large/complex, please ensure that you have either created an issue that the team's had a chance to respond to, or had some discussion with the team prior to submitting substantial pull requests. The team can be reached via GitHub Discussions or the Cosmos Network Discord server in the #cometbft channel. GitHub Discussions is preferred over Discord as it allows us to keep track of conversations topically. https://github.com/cometbft/cometbft/discussions If the work in this PR is not aligned with the team's current priorities, please be advised that it may take some time before it is merged - especially if it has not yet been discussed with the team. See the project board for the team's current priorities: https://github.com/orgs/cometbft/projects/1 --> --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Sergio Mena <sergio@informal.systems> (cherry picked from commit d342b3a)
4 tasks
melekes
added a commit
that referenced
this pull request
Apr 29, 2024
…2922) and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and `types.SimpleValidator`. Closes #2878 Follow-up to #2843 --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2890 done by [Mergify](https://mergify.com). Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
PubKeyinabci.ValidatorUpdateand adds two new fields:PubKeyTypePubKeyBytesCo-authored by: @tac0turtle
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments