Skip to content

feat(proto)!: replace pub_key with pub_key_type (backport #2890)#2922

Merged
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2890
Apr 29, 2024
Merged

feat(proto)!: replace pub_key with pub_key_type (backport #2890)#2922
melekes merged 1 commit intov1.xfrom
mergify/bp/v1.x/pr-2890

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 29, 2024

and pub_key_bytes in privval.PubKeyResponse, types.Validator and types.SimpleValidator.

Closes #2878
Follow-up to #2843


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2890 done by [Mergify](https://mergify.com).

and `pub_key_bytes` in `privval.PubKeyResponse`, `types.Validator` and
`types.SimpleValidator`.

Closes #2878
Follow-up to #2843
<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
(cherry picked from commit d342b3a)
@mergify mergify bot requested a review from a team as a code owner April 29, 2024 05:55
@mergify mergify bot requested a review from a team April 29, 2024 05:55
@melekes melekes merged commit 4d7da6b into v1.x Apr 29, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2890 branch April 29, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant