Skip to content

feat(proto)!: replace PubKey in abci.ValidatorUpdate with PubKeyType and PubKeyBytes (backport #2843)#2879

Merged
melekes merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2843
Apr 24, 2024
Merged

feat(proto)!: replace PubKey in abci.ValidatorUpdate with PubKeyType and PubKeyBytes (backport #2843)#2879
melekes merged 3 commits intov1.xfrom
mergify/bp/v1.x/pr-2843

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 23, 2024

This PR deprecates PubKey in abci.ValidatorUpdate and adds two new fields:

  • string PubKeyType
  • bytes PubKeyBytes

Co-authored by: @tac0turtle


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2843 done by [Mergify](https://mergify.com).

…Type` and `PubKeyBytes` (#2843)

This PR deprecates `PubKey` in `abci.ValidatorUpdate` and adds two new
fields:

- string `PubKeyType`
- bytes `PubKeyBytes`

Co-authored by: @tac0turtle

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com>
Co-authored-by: Andy Nogueira <me@andynogueira.dev>
(cherry picked from commit 71cd087)

# Conflicts:
#	abci/example/kvstore/kvstore.go
@mergify mergify bot requested review from a team as code owners April 23, 2024 16:42
@mergify mergify bot requested a review from a team April 23, 2024 16:42
@mergify
Copy link
Contributor Author

mergify bot commented Apr 23, 2024

Cherry-pick of 71cd087 has failed:

On branch mergify/bp/v1.x/pr-2843
Your branch is up to date with 'origin/v1.x'.

You are currently cherry-picking commit 71cd08774.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .changelog/unreleased/breaking-changes/2843-abci-types-go-api.md
	new file:   .changelog/unreleased/breaking-changes/2843-abci-types-validator-update-pubkey.md
	new file:   .changelog/unreleased/breaking-changes/2843-proto-abci-v1-validator-update.md
	modified:   abci/example/kvstore/helpers.go
	modified:   abci/example/kvstore/kvstore_test.go
	modified:   abci/tests/server/client.go
	modified:   abci/types/pubkey.go
	modified:   abci/types/util.go
	modified:   api/cometbft/abci/v1/types.pb.go
	modified:   crypto/encoding/codec.go
	new file:   crypto/encoding/codec_test.go
	modified:   internal/consensus/common_test.go
	modified:   internal/consensus/reactor_test.go
	modified:   internal/consensus/replay.go
	modified:   internal/consensus/replay_test.go
	modified:   proto/cometbft/abci/v1/types.proto
	modified:   proto/cometbft/types/v1/params.proto
	modified:   rpc/client/evidence_test.go
	modified:   spec/abci/abci++_methods.md
	modified:   spec/core/state.md
	modified:   state/execution.go
	modified:   state/execution_test.go
	modified:   state/helpers_test.go
	modified:   state/state_test.go
	modified:   test/e2e/app/app.go
	modified:   types/params_test.go
	modified:   types/protobuf.go
	modified:   types/protobuf_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   abci/example/kvstore/kvstore.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Apr 23, 2024
@melekes melekes merged commit a761a87 into v1.x Apr 24, 2024
@melekes melekes deleted the mergify/bp/v1.x/pr-2843 branch April 24, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants