Merged
Conversation
adizere
approved these changes
Apr 4, 2024
Contributor
adizere
left a comment
There was a problem hiding this comment.
Left two small remarks, fine to ignore if I'm missing something or you disagree. Otherwise LGTM!
Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
close: #2707 - Renames ABCI++ to the appropriate name: - Related to `PrepareProposal` or `ProcessProposal` => `ABCI 1.0` - Related to `FinalizeBlock` or `vote extensions` => `ABCI 2.0` - Anything else => `ABCI` > NOTE: Filenames were not renamed if they have `abci++` in their name. These would be a major breaking change to external sites (e.g. Cosmos SDK docs) pointing to CometBFT website and since we don't support redirects in our docs website, it doesn't make sense to rename this files. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec --------- Co-authored-by: Adi Seredinschi <adizere@gmail.com> Co-authored-by: Daniel <daniel.cason@informal.systems> (cherry picked from commit c3acea2)
4 tasks
andynog
added a commit
that referenced
this pull request
Apr 9, 2024
close: #2707 - Renames ABCI++ to the appropriate name: - Related to `PrepareProposal` or `ProcessProposal` => `ABCI 1.0` - Related to `FinalizeBlock` or `vote extensions` => `ABCI 2.0` - Anything else => `ABCI` > NOTE: Filenames were not renamed if they have `abci++` in their name. These would be a major breaking change to external sites (e.g. Cosmos SDK docs) pointing to CometBFT website and since we don't support redirects in our docs website, it doesn't make sense to rename this files. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments - [X] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request #2712 done by [Mergify](https://mergify.com). Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #2707
PrepareProposalorProcessProposal=>ABCI 1.0FinalizeBlockorvote extensions=>ABCI 2.0ABCIPR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments