Skip to content

spec: Rename ABCI++ in the spec (backport #2712)#2759

Merged
andynog merged 2 commits intov1.xfrom
mergify/bp/v1.x/pr-2712
Apr 9, 2024
Merged

spec: Rename ABCI++ in the spec (backport #2712)#2759
andynog merged 2 commits intov1.xfrom
mergify/bp/v1.x/pr-2712

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 9, 2024

close: #2707

  • Renames ABCI++ to the appropriate name:
    • Related to PrepareProposal or ProcessProposal => ABCI 1.0
    • Related to FinalizeBlock or vote extensions => ABCI 2.0
    • Anything else => ABCI

NOTE: Filenames were not renamed if they have abci++ in their name. These would be a major breaking change to external sites (e.g. Cosmos SDK docs) pointing to CometBFT website and since we don't support redirects in our docs website, it doesn't make sense to rename this files.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

This is an automatic backport of pull request #2712 done by [Mergify](https://mergify.com).

close: #2707

- Renames ABCI++ to the appropriate name:
  - Related to `PrepareProposal` or `ProcessProposal` => `ABCI 1.0`
  - Related to `FinalizeBlock` or `vote extensions` => `ABCI 2.0`
  - Anything else => `ABCI`

> NOTE: Filenames were not renamed if they have `abci++` in their name.
These would be a major breaking change to external sites (e.g. Cosmos
SDK docs) pointing to CometBFT website and since we don't support
redirects in our docs website, it doesn't make sense to rename this
files.

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [X] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Daniel <daniel.cason@informal.systems>
(cherry picked from commit c3acea2)
@mergify mergify bot requested review from a team as code owners April 9, 2024 13:03
Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andynog andynog merged commit 81ca652 into v1.x Apr 9, 2024
@andynog andynog deleted the mergify/bp/v1.x/pr-2712 branch April 9, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant