feat(e2e): introduce oscillations for validators and consensus params#2283
Merged
feat(e2e): introduce oscillations for validators and consensus params#2283
Conversation
4 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
4 tasks
sergio-mena
commented
Sep 20, 2024
sergio-mena
commented
Sep 20, 2024
1 task
sergio-mena
commented
Sep 20, 2024
Collaborator
Author
|
@hvanz would you mind checking the part of this PR that touches on lanes? |
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Hernán Vanzetto <15466498+hvanz@users.noreply.github.com>
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
…idator (#4473) This issue was introduced by #2283. I've sneaked in a minor change in the script, so that we can grep for "Testnet failed" and go directly to the right manifests. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
…nifests (#4478) Workaround for #4492. This PR: 1. Describes the issue with introduced by #2283 in comments in the source code (check FIXMEs and TODOs) 2. Temporarily disables the validator set oscillations in the generated manifest, used in nightly runs Item 2. has the side effect that not only the validator set oscillations but also the consensus params oscillations are disabled, while we are only aware of issues in the former. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments --------- Co-authored-by: Andy Nogueira <me@andynogueira.dev> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #2458
This PR adds a new config to the
e2emanifest that causes thee2eapp to flip, at every height:This allows us to simulate chains with changes to these data structures at every height.
IMPORTANT: Do not review commit by commit, as I radically changed the approach to flipping validators (to another way more surgical)
PR checklist
[ ] Changelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments