Skip to content

fix(e2e): do not oscilate validator set when it contains a single validator#4473

Merged
cason merged 2 commits intomainfrom
cason/e2e-flip-fix
Nov 12, 2024
Merged

fix(e2e): do not oscilate validator set when it contains a single validator#4473
cason merged 2 commits intomainfrom
cason/e2e-flip-fix

Conversation

@cason
Copy link

@cason cason commented Nov 12, 2024

This issue was introduced by #2283.

I've sneaked in a minor change in the script, so that we can grep for "Testnet failed" and go directly to the right manifests.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@cason cason requested a review from a team as a code owner November 12, 2024 08:02
@cason cason requested a review from a team November 12, 2024 08:02
@cason cason changed the title fiex(e2e): do not oscilate validator set when it contains a single validator fix(e2e): do not oscilate validator set when it contains a single validator Nov 12, 2024
@cason cason self-assigned this Nov 12, 2024
@cason cason added e2e Related to our end-to-end tests bug Something isn't working labels Nov 12, 2024
Copy link
Collaborator

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@andynog andynog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, that's exactly what I had in my branch but I didn't push a PR since I was waiting on validation. This fixes the problem.

@cason cason added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 37b1a60 Nov 12, 2024
@cason cason deleted the cason/e2e-flip-fix branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working e2e Related to our end-to-end tests

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants