fix(e2e): temporary disable validator set oscillation in generated manifests#4478
fix(e2e): temporary disable validator set oscillation in generated manifests#4478
Conversation
|
@cason please let me know if you need help with this. I was looking at the initial implementation and it seems you are going into the direction of adding validator updates to the manifest.toml file (?). This will probably need some changes to the generator too. |
Yes, I need. The The problem is that in the new logic, the The problem is that the updates produced by the generator (which are more relevant changes) might conflict with the validator updates produced by the oscillation logic (which just turn on and off a validator, with voting power 1 and 0). The latter has to be fixed. |
|
By the way, if no one has bandwidth to proceed on this work, we should open an issue. Until then, as workaround, we should probably disable the |
|
@andynog, feel free to merge it if you find it legit. So we don't have that much failures from this night's tests. |
Workaround for #4492.
This PR:
Item 2. has the side effect that not only the validator set oscillations but also the consensus params oscillations are disabled, while we are only aware of issues in the former.
PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments