-
Notifications
You must be signed in to change notification settings - Fork 780
Closed
Labels
P:tech-debtPriority: Technical debt that needs to be paid off to enable us to move faster, reliablyPriority: Technical debt that needs to be paid off to enable us to move faster, reliablyconfigdependenciesDependency updatesDependency updatesstoragetrackingA complex issue broken down into sub-problemsA complex issue broken down into sub-problems
Description
Partially addresses #1039.
Context
The work in this issue will make CometBFT use only pebbleDB as database, thus deprecating cometbft-db.
As CometBFT will use the same DB interface that cometbft-db uses, users can provide their own implementation of the interface that uses a different database under the hood. They will, therefore, have to change the config.DefaultDBProvider function to return their implementation instead of our default.
However, we will support and maintain only the pebbleDB implementation of the DB interface that CometBFT will use.
ToDo
- Create
internal/storagepkg to port theDBinterface and pebbleDB's implementation of it that are currently in cometbft-db. - Add tests for pebble functionalities.
-
DBinteface. Merged with feat(storage): Add unit tests for pebble implementation ofDBinterface. #4515 -
Batchinterface. Merged with feat(storage): Add unit tests for pebble implementation ofBatchinterface. #4522 -
Iteratorinterface. Merged: feat(storage): Add unit tests for pebble implementation ofIteratorinterface. #4530
-
- Import
PrefixDBimplementation. Merged: feat(storage): AddPrefixDBto pkginternal/storage#4562 - Remove cometbft-db as a dependency. WIP: build(deps): CometBFT no longer imports
cometbft-db#4601 - Remove
DBBackendfield ofconfig.BaseConfigand from config options in toml. chore: removedb_backendconfig option and CLI argument #4915 - Remove cometbft-db from cometbft build process. Merged with build(deps): Remove cometbft-db from cometbft build. #4650
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P:tech-debtPriority: Technical debt that needs to be paid off to enable us to move faster, reliablyPriority: Technical debt that needs to be paid off to enable us to move faster, reliablyconfigdependenciesDependency updatesDependency updatesstoragetrackingA complex issue broken down into sub-problemsA complex issue broken down into sub-problems