chore: remove db_backend config option and CLI argument#4915
Merged
melekes merged 6 commits intofeature/remove-cometbftdbfrom Feb 4, 2025
Merged
chore: remove db_backend config option and CLI argument#4915melekes merged 6 commits intofeature/remove-cometbftdbfrom
db_backend config option and CLI argument#4915melekes merged 6 commits intofeature/remove-cometbftdbfrom
Conversation
zrbecker
reviewed
Feb 3, 2025
zrbecker
reviewed
Feb 3, 2025
|
|
||
| for i := int64(0); i < numTxs; i++ { | ||
| msg2 := <-txsSub.Out() | ||
| var msg2 cmtpubsub.Message |
There was a problem hiding this comment.
Did we turn this into a select statement due to a test failing?
Looks like this catches the service stopping, or the event queue being closed. Not sure what that has to do with removing the db-backend options and commands though.
Collaborator
Author
There was a problem hiding this comment.
No, it was a general improvement. Not related to this PR.
zrbecker
approved these changes
Feb 3, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also
experimental-compact-goleveldbcommandcometbft-db#4868 (comment)