feat(storage): Add unit tests for pebble implementation of DB interface.#4515
Merged
alesforz merged 14 commits intofeature/remove-cometbftdbfrom Nov 21, 2024
Merged
feat(storage): Add unit tests for pebble implementation of DB interface.#4515alesforz merged 14 commits intofeature/remove-cometbftdbfrom
DB interface.#4515alesforz merged 14 commits intofeature/remove-cometbftdbfrom
Conversation
added 2 commits
November 19, 2024 18:08
Rewrote unit test for the set operation to test the behavior of `setWithOpts`. This should be sufficient to test the Set and SetSync methods, because under the hood they only differ in that they call setWithOpts with pebble.NoSync and pebble.Sync respectively.
9 tasks
DB interface.
added 11 commits
November 20, 2024 10:07
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #4486.
Context
CometBFT will stop importing cometbft-db as a dependency to support multiple database backends. Instead, it will use pebble by default.
Changes
This PR adds unit tests to the pebble implementation of the
DBinterface that CometBFT will use once we remove cometbft-db.PR checklist
[ ] Changelog entry added in.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments