build(deps): Remove cometbft-db from cometbft build.#4650
Merged
alesforz merged 5 commits intofeature/remove-cometbftdbfrom Dec 12, 2024
Merged
build(deps): Remove cometbft-db from cometbft build.#4650alesforz merged 5 commits intofeature/remove-cometbftdbfrom
alesforz merged 5 commits intofeature/remove-cometbftdbfrom
Conversation
added 2 commits
December 12, 2024 12:29
Collaborator
Author
|
Should we update the docs about how to build cometbft in this PR, or as part of a single future PR (to be merged in the feature branch as well) in which we update ALL the docs to remove mentions to cometbft-db and add new information? |
Collaborator
|
I am in favor of doing this separately as it can take a lot of time, and it should not block the implementation. Make sure we have an issue for it. |
melekes
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #4486.
This PR removes cometbft-db from cometbft build process:
Note to Reviewers
Please add in the discussion below any file that I have forgotten to update.
PR checklist
[ ] Tests written/updated[ ] Changelog entry added in.changelog(we use unclog to manage our changelog)[ ] Updated relevant documentation (docs/orspec/) and code comments