sql/schemachanger: remove oprules from declarative schema changer#96769
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Feb 9, 2023
Merged
sql/schemachanger: remove oprules from declarative schema changer#96769craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Previously, when the declarative schema changer invoked, not implemented operations they would be no-ops. This patch, adds assertion that fail these operations, except for certain cases where these operations should be no-ops for dropped descriptors. Epic: none Release note: None
Member
|
This change is |
f3d885a to
e8a1d7c
Compare
ajwerner
approved these changes
Feb 8, 2023
Collaborator
Author
|
@ajwerner TFTR! |
adaa601 to
1b2184a
Compare
Previously, oprules in the declarative schema changer would be used to skip op edges on certain dropped elements (columns and descriptors). This made it harder to understand behaviour of the declarative schema changer. To address this, this patch removes this logic, and adds support for skipping operations during runtime instead. Epic: none Release note: None
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
postamar
pushed a commit
to postamar/cockroach
that referenced
this pull request
May 23, 2023
This commit is a follow-up to cockroachdb#96769 which removes superfluous test definitions. Informs cockroachdb#96769. Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 23, 2023
103148: server: server identity returns nodeID for system tenant r=aadityasondhi a=dhartunian Previously, the server identity object would hide the nodeID from identity objects that contained a set tenantID. This was done to create separation of concerns between a secondary tenant and the rest of the cluster. However, this identity is used in populating log payloads with contextual metadata. That led to #103112 due to the fact that the system tenant sets its tenantId to 1 which led to a hidden nodeID. We now always emit the nodeID when the tenantID is set to the system tenant. Fixes #103112 Release note (bug fix): 23.1.0 contained a bug where the `node_id` field would be omitted in logs. This fix restores that value. 103709: server,jobs: Better handle node drain r=miretskiy a=miretskiy Rework job registry drain signal to terminate the drain as soon as the last job that was watching for drain signal completes its drain Epic: CRDB-26978 Release note: None 103781: rules: add deprecation notices, remove op-rule tests r=postamar a=postamar This commit is a follow-up to #96769 which removes superfluous test definitions. Informs #96769. Release note: None 103792: sql/opt: deflake TestExecBuild/autocommit r=knz a=nvanbenschoten Fixes #103772. The test became flaky after 3fc29ad, which causes intent resolution to end up in foreground requests' traces. Release note: None Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com> Co-authored-by: Marius Posta <marius@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will do the following: