Skip to content

sql: flake in TestExecBuild/autocommit due to non-deterministic ResolveIntent in KV batch #103772

@knz

Description

@knz

Describe the problem
Observed here

=== RUN   TestExecBuild_autocommit
initialized metamorphic constant "logictest-global-mvcc-range-tombstone" with value true
initialized metamorphic constant "logictest-use-mvcc-range-tombstones-for-point-deletes" with value true
I230523 11:14:31.113596 1 (gostd) rand.go:243  [-] 1  random seed: 443818906144832873
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/56e1e960ced543bbe2593e1496bb4696/logTestExecBuild_autocommit3512975457
    test_log_scope.go:79: use -show-logs to present logs inline
    logic.go:2940: let $rangeid = 63
    logic.go:2894:
        /home/roach/.cache/bazel/_bazel_roach/c5a4e7d36696d9cd970af2045211a7df/sandbox/processwrapper-sandbox/12742/execroot/com_github_cockroachdb_cockroach/bazel-out/k8-fastbuild/bin/pkg/sql/opt/exec/execbuilder/tests/local/local_test_/local_test.runfiles/com_github_cockroachdb_cockroach/pkg/sql/opt/exec/execbuilder/testdata/autocommit:678: SELECT operation, message FROM [SHOW KV TRACE FOR SESSION]
        WHERE message       LIKE '%r63: sending batch%'
          AND message   NOT LIKE '%PushTxn%'
          AND message   NOT LIKE '%QueryTxn%'
          AND operation NOT LIKE '%async%'
        expected:
            dist sender send  r63: sending batch 2 CPut to (n1,s1):1
            dist sender send  r63: sending batch 2 Get to (n1,s1):1
            dist sender send  r63: sending batch 1 EndTxn to (n1,s1):1
        but found (query options: "") :
            dist sender send  r63: sending batch 2 CPut to (n1,s1):1
            dist sender send  r63: sending batch 2 Get to (n1,s1):1
            dist sender send  r63: sending batch 1 ResolveIntent to (n1,s1):1
            dist sender send  r63: sending batch 1 EndTxn to (n1,s1):1

Expected behavior

check why this ResolveIntent is in there (this is a new failure mode)
And potentially make the test impervious to it.

cc @nvanbenschoten @mgartner

Jira issue: CRDB-28194

Metadata

Metadata

Assignees

Labels

A-kvAnything in KV that doesn't belong in a more specific category.A-sql-executionRelating to SQL execution.C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.C-test-failureBroken test (automatically or manually discovered).T-sql-queriesSQL Queries Team

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions