103148: server: server identity returns nodeID for system tenant r=aadityasondhi a=dhartunian Previously, the server identity object would hide the nodeID from identity objects that contained a set tenantID. This was done to create separation of concerns between a secondary tenant and the rest of the cluster. However, this identity is used in populating log payloads with contextual metadata. That led to #103112 due to the fact that the system tenant sets its tenantId to 1 which led to a hidden nodeID. We now always emit the nodeID when the tenantID is set to the system tenant. Fixes #103112 Release note (bug fix): 23.1.0 contained a bug where the `node_id` field would be omitted in logs. This fix restores that value. 103709: server,jobs: Better handle node drain r=miretskiy a=miretskiy Rework job registry drain signal to terminate the drain as soon as the last job that was watching for drain signal completes its drain Epic: CRDB-26978 Release note: None 103781: rules: add deprecation notices, remove op-rule tests r=postamar a=postamar This commit is a follow-up to #96769 which removes superfluous test definitions. Informs #96769. Release note: None 103792: sql/opt: deflake TestExecBuild/autocommit r=knz a=nvanbenschoten Fixes #103772. The test became flaky after 3fc29ad, which causes intent resolution to end up in foreground requests' traces. Release note: None Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com> Co-authored-by: Marius Posta <marius@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>

log: node_id field missing in log metadata #103112

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions