This change fixes decommission roachtests to properly be aware of the
new output introduced by cockroachdb#96100, and to utilize the decommission
pre-checks accordingly. In some places, the decommission pre-checks are
skipped, especially because the decommission used in the test is not
expected to be completeable.

Fixes: cockroachdb#98026, cockroachdb#98018, cockroachdb#98017.

Release note: None

This change fixes decommission roachtests to properly be aware of the
new output introduced by cockroachdb#96100, and to utilize the decommission
pre-checks accordingly. In some places, the decommission pre-checks are
skipped, especially because the decommission used in the test is not
expected to be completeable.

Fixes: cockroachdb#98026, cockroachdb#98018, cockroachdb#98017.

Release note: None

97766: kvflowcontrol: implement kvflowcontrol.Dispatch r=irfansharif a=irfansharif

Part of #95563. Dispatch is a concrete implementation of the kvflowcontrol.Dispatch interface. It's used to dispatch information about admitted raft log entries to the specific nodes where (i) said entries originated, (ii) flow tokens were deducted and (iii) are waiting to be returned. This type is also used to read pending dispatches, which will be used in the raft transport layer when looking to piggyback information on traffic already bound to specific nodes. Since timely dispatching (read: piggybacking) is not guaranteed, we allow querying for all long-overdue dispatches.

Internally it's able to coalesce dispatches bound for a given node. If dispatching admission information for two log entries with the same <RangeID,StoreID,WorkPriority> triple, with log positions L1 and L2 where L1 < L2, we can simply dispatch the one with L2. We leave the integration of this type with the {Store,}WorkQueue (#97599) + raft transport to future PRs.

Release note: None

97826: sql: introduce array_cat_agg aggregate builtin r=yuzefovich a=yuzefovich

This commit introduces a new `array_cat_agg` aggregate builtin function
that takes in an array type as its input, and then unnests each array
and appends all its elements into a single result array. In other
words, it behaves similar to `array_agg(unnest(array_column))`. This
function doesn't have an analogue in Postgres. However, some of our SQL
observability tools need this functionality, and the current workaround
of using a LATERAL JOIN often results in slow apply joins, so this new
builtin should speed things up significantly. In particular,
`crdb_internal.statement_statistics` view is now refactored to use the
new builtin which removes an apply join from it. The choice of this
particular name comes from the fact that we have the `array_cat` builtin
which concatenates two arrays.

Fixes: #97502.

Release note (sql change): New aggregate builtin function
`array_cat_agg` is introduced. It behaves similar to how
`array_agg(unnest(array_column))` would - namely, it takes arrays as its
input, unnests them into the array elements which are then aggregated
into a single result array (i.e. it's similar to concatenating all input
arrays into a single one).

98079: generate-bazel-extra: add instructions to update timeouts list r=rickystewart a=healthy-pod

This code change removes `pkg/ccl/backupccl` from the really enormous targets list because it's only there for CI stress purposes.

It also adds instructions to follow when adding a new test target to the list of really enormous timeouts.

Release note: None
Epic: none

98113: roachtest: decommission roachtests conform to new output r=kvoli a=AlexTalks

This change fixes decommission roachtests to properly be aware of the new output introduced by #96100, and to utilize the decommission pre-checks accordingly. In some places, the decommission pre-checks are skipped, especially because the decommission used in the test is not expected to be completeable.

Fixes: #98026, #98018, #98017.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: healthy-pod <ahmad@cockroachlabs.com>
Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com>

With the introduction of decommission pre-checks executed by the CLI in cockroachdb#96100,
the decommission readiness was used to exit with a non-zero exit code
when a node is not ready to be decommissioned. However, as the
decommission command is intended to be idempotent, decommissioning an
already decommissioned node should not be considered an error,
especially since we already print a warning stating as such. This change
fixes that check to exit with a code of 0 if a node has already been
decommissioned.

Fixes: cockroachdb#98149.

Release note (cli change): Running `cockroch node decommission <nodeID>`
for a node that has already been decommissioned will now exit with code
0, as had been the case in CockroachDB versions prior to 23.1.0.

With the introduction of decommission pre-checks executed by the CLI in cockroachdb#96100,
the decommission readiness was used to exit with a non-zero exit code
when a node is not ready to be decommissioned. However, as the
decommission command is intended to be idempotent, decommissioning an
already decommissioned node should not be considered an error,
especially since we already print a warning stating as such. This change
fixes that check to exit with a code of 0 if a node has already been
decommissioned.

Fixes: cockroachdb#98149.

Release note (cli change): Running `cockroch node decommission <nodeID>`
for a node that has already been decommissioned will now exit with code
0, as had been the case in CockroachDB versions prior to 23.1.0.

103555: cli: exit without error on repeated decommission r=AlexTalks a=AlexTalks

With the introduction of decommission pre-checks executed by the CLI in #96100, the decommission readiness was used to exit with a non-zero exit code when a node is not ready to be decommissioned. However, as the decommission command is intended to be idempotent, decommissioning an already decommissioned node should not be considered an error, especially since we already print a warning stating as such. This change fixes that check to exit with a code of 0 if a node has already been decommissioned.

Fixes: #98149.

Release note (cli change): Running `cockroch node decommission <nodeID>` for a node that has already been decommissioned will now exit with code 0, as had been the case in CockroachDB versions prior to 23.1.0.

Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com>

With the introduction of decommission pre-checks executed by the CLI in #96100,
the decommission readiness was used to exit with a non-zero exit code
when a node is not ready to be decommissioned. However, as the
decommission command is intended to be idempotent, decommissioning an
already decommissioned node should not be considered an error,
especially since we already print a warning stating as such. This change
fixes that check to exit with a code of 0 if a node has already been
decommissioned.

Fixes: #98149.

Release note (cli change): Running `cockroch node decommission <nodeID>`
for a node that has already been decommissioned will now exit with code
0, as had been the case in CockroachDB versions prior to 23.1.0.

This change adds a new interactive tests for the decommission pre-checks
executed by the CLI that were introduced in cockroachdb#96100. The tests validate
the output and exit codes of the decommission command when the
pre-checks are enabled (as they are by default).

Epic: none

Release note: none