roachtest: decommission roachtests conform to new output#98113
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 7, 2023
Merged
roachtest: decommission roachtests conform to new output#98113craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
kvoli
approved these changes
Mar 7, 2023
Contributor
kvoli
left a comment
There was a problem hiding this comment.
Csn you open an issue to add prechecks back to the roachtest in the future?
This change fixes decommission roachtests to properly be aware of the new output introduced by cockroachdb#96100, and to utilize the decommission pre-checks accordingly. In some places, the decommission pre-checks are skipped, especially because the decommission used in the test is not expected to be completeable. Fixes: cockroachdb#98026, cockroachdb#98018, cockroachdb#98017. Release note: None
9f3d10a to
db2f1aa
Compare
Contributor
Author
|
bors r=kvoli |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
AlexTalks
added a commit
to AlexTalks/cockroach
that referenced
this pull request
Jul 14, 2023
Once decommission pre-checks were introduced, in cockroachdb#98113 the roachtests were updated to handle the new output in certain cases. Despite this, it was not handled in all cases and in the `decommission/mixed-versions` test, which upgrades and restarts nodes, decommission requests that happen shortly after restart could fail the pre-checks because nodes are considered "suspect" for 30s after being unavailable. This change decreases the suspect time limit and ensures that the nodes are considered fully available before decommissioning, with pre-checks enabled. Fixes: cockroachdb#101620 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
106642: geos: update GEOS to 3.11 r=sumeerbhola,rickystewart a=otan All test changes are due to a change in Polygon output ordering, or GEOS outputting a different yet valid result. Note we stop supporting windows as a result. Release note (general change): Spatial libraries from Cockroach now rely on GEOS 3.11 instead of GEOS 3.8. Epic: none Release note (general change): Stop distributing `libgeos` for (experimental) Windows build. Users can instead install GEOS directly from source: https://libgeos.org/usage/download/. 106859: roachtest: avoid decommissioning suspect nodes in mixed version test r=AlexTalks a=AlexTalks Once decommission pre-checks were introduced, in #98113 the roachtests were updated to handle the new output in certain cases. Despite this, it was not handled in all cases and in the `decommission/mixed-versions` test, which upgrades and restarts nodes, decommission requests that happen shortly after restart could fail the pre-checks because nodes are considered "suspect" for 30s after being unavailable. This change decreases the suspect time limit and ensures that the nodes are considered fully available before decommissioning, with pre-checks enabled. Fixes: #101620 Release note: None Co-authored-by: Oliver Tan <otan@cockroachlabs.com> Co-authored-by: Alex Sarkesian <sarkesian@cockroachlabs.com>
AlexTalks
added a commit
that referenced
this pull request
Jul 18, 2023
Once decommission pre-checks were introduced, in #98113 the roachtests were updated to handle the new output in certain cases. Despite this, it was not handled in all cases and in the `decommission/mixed-versions` test, which upgrades and restarts nodes, decommission requests that happen shortly after restart could fail the pre-checks because nodes are considered "suspect" for 30s after being unavailable. This change decreases the suspect time limit and ensures that the nodes are considered fully available before decommissioning, with pre-checks enabled. Fixes: #101620 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes decommission roachtests to properly be aware of the new output introduced by #96100, and to utilize the decommission pre-checks accordingly. In some places, the decommission pre-checks are skipped, especially because the decommission used in the test is not expected to be completeable.
Fixes: #98026, #98018, #98017.
Release note: None