generate-bazel-extra: add instructions to update timeouts list#98079
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 7, 2023
Merged
generate-bazel-extra: add instructions to update timeouts list#98079craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
rickystewart
approved these changes
Mar 6, 2023
pkg/cmd/generate-bazel-extra/main.go
Outdated
| // your change in `pkg/cmd/teamcity-trigger` by updating `customTimeouts`. | ||
| // 3. You should only add a test target here if it's for stand-alone testing. | ||
| // For example: `/pkg/sql/sqlitelogictest` is only tested in a nightly in | ||
| // `build/teamcity/cockroach/nightlies/sqlite_logic_test_impl.sh`. |
Collaborator
There was a problem hiding this comment.
Maybe a comment like: "If this is the case, you should tag your test as integration" so it is not run in CI.
This code change removes `pkg/ccl/backupccl` from the really enormous targets list because it's only there for CI stress purposes. It also adds instructions to follow when adding a new test target to the list of really enormous timeouts. Release note: None Epic: none
373425d to
2823c0b
Compare
Contributor
Author
|
bors r=rickystewart |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code change removes
pkg/ccl/backupcclfrom the really enormous targets list because it's only there for CI stress purposes.It also adds instructions to follow when adding a new test target to the list of really enormous timeouts.
Release note: None
Epic: none