githooks: improve UX of release note template#87176
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 1, 2022
Merged
githooks: improve UX of release note template#87176craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Now you can just select the one you like, which at least for me is None a lot of the time. Sample: https://gist.github.com/tbg/5e77e1baea1ce5e26817587b3a45c991 Release justification: CRL eng UX improvement Release note: None
Member
|
This change is |
rickystewart
approved these changes
Aug 31, 2022
Member
Author
|
bors r=rickystewart |
Contributor
|
Build succeeded: |
maryliag
added a commit
to maryliag/cockroach
that referenced
this pull request
Sep 6, 2022
The PR cockroachdb#87176 introduced improvements on the Release note template, but it didn't have the space required between `note` and `(...`. This commit adds the space so you can select the proper release note and don't get a error message about the missing space. Release justification: CRL end UX improvement Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
87453: authors: add andrew.zhang to authors r=ayz-lex a=ayz-lex Release note: None Release justification: non-production code change. 87458: ui: showing ALTER index recommendations r=maryliag a=maryliag With the new index recommendation type introduced on #87174, this commit does the proper handle of the alter option and show the recommendation with its proper docs accordingly. Fixes #87414 Rename "Create new index" to "Create Index" Release justification: low risk change Release note (ui change): Showing index recommendation of `ALTER index` type (both in Statement Details page and on Insights page). 87460: githooks: fix UX of release note template r=maryliag a=maryliag The PR #87176 introduced improvements on the Release note template, but it didn't have the space required between `note` and `(...`. This commit adds the space so you can select the proper release note and don't get a error message about the missing space. Release justification: CRL end UX improvement Release note: None Co-authored-by: Andrew Zhang <andrewyzhanglex@gmail.com> Co-authored-by: Marylia Gutierrez <marylia@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can just select the one you like, which at least for me is None
a lot of the time.
Sample: https://gist.github.com/tbg/5e77e1baea1ce5e26817587b3a45c991
Release justification: CRL eng UX improvement
Release note: None