ui: showing ALTER index recommendations#87458
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 7, 2022
Merged
Conversation
Member
|
This change is |
With the new index recommendation type introduced on cockroachdb#87174, this commit does the proper handle of the alter option and show the recommendation with its proper docs accordingly. Fixes cockroachdb#87414 Rename "Create new index" to "Create Index" Release justification: low risk change Release note (ui change): Showing index recommendation of `ALTER index` type (both in Statement Details page and on Insights page).
1706e30 to
8d41444
Compare
j82w
approved these changes
Sep 6, 2022
Contributor
j82w
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new index recommendation type introduced
on #87174, this commit does the proper handle of
the alter option and show the recommendation with
its proper docs accordingly.
Fixes #87414
Rename "Create new index" to "Create Index"
Release justification: low risk change
Release note (ui change): Showing index recommendation
of
ALTER indextype (both in Statement Detailspage and on Insights page).