githooks: fix UX of release note template#87460
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 7, 2022
Merged
githooks: fix UX of release note template#87460craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The PR cockroachdb#87176 introduced improvements on the Release note template, but it didn't have the space required between `note` and `(...`. This commit adds the space so you can select the proper release note and don't get a error message about the missing space. Release justification: CRL end UX improvement Release note: None
Member
|
This change is |
ajwerner
approved these changes
Sep 6, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
Contributor
Author
|
bors r+ |
rickystewart
approved these changes
Sep 6, 2022
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #87176 introduced improvements on the
Release note template, but it didn't have the
space required between
noteand(....This commit adds the space so you can select the
proper release note and don't get a error message
about the missing space.
Release justification: CRL end UX improvement
Release note: None