spanconfig: ensure single reconciliation job post-restore#79222
Closed
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Closed
spanconfig: ensure single reconciliation job post-restore#79222irfansharif wants to merge 2 commits intocockroachdb:masterfrom
irfansharif wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Release note: none.
Member
|
This change is |
Fixes cockroachdb#70173. When restoring a cluster, we don't want to end up with two instances of the singleton reconciliation job. Release note: None
2499d82 to
888543f
Compare
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Apr 1, 2022
Closes cockroachdb#75060; speculating that cockroachdb#79222 fixed the underlying issue. Previously the reconciliation job errored out with "expected to delete 11 row(s), deleted 10", which could conceivably occur if there were two instances of the reconciliation job running post-restore (something \cockroachdb#79222 fixes). Release note: None
Contributor
Author
|
David ended up reviewing this as part of #79228, just going to run with it. |
craig bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
79228: backupccl: run TestFullClusterBackup with span configs r=irfansharif a=irfansharif Closes #75060; speculating that #79222 fixed the underlying issue. Previously the reconciliation job errored out with "expected to delete 11 row(s), deleted 10", which could conceivably occur if there were two instances of the reconciliation job running post-restore (something \#79222 fixes). Release note: None --- First two commits are from #79139 and #79222 respectively. Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70173. When restoring a cluster, we don't want to end up with two
instances of the singleton reconciliation job.
Release note: None
First commit is from #79139.