jobs: record creation cluster ID and version#79139
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 1, 2022
Merged
jobs: record creation cluster ID and version#79139craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
|
Can you provide a bit more context as to why we need this? |
Release note: none.
eb1154c to
cbe38b4
Compare
Contributor
Author
|
added comments to the fields |
Contributor
|
To confirm: Do we want this on jobs level? and not per-job implementation? |
Contributor
Author
Jobs level here is just capturing the info about when a job was made; what to do with it is up to per-job logic. |
irfansharif
approved these changes
Apr 1, 2022
Contributor
Author
|
@miretskiy did you have a concern about it or just curious about the expected usage? |
Contributor
|
No concerns, just curious. |
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
79228: backupccl: run TestFullClusterBackup with span configs r=irfansharif a=irfansharif Closes #75060; speculating that #79222 fixed the underlying issue. Previously the reconciliation job errored out with "expected to delete 11 row(s), deleted 10", which could conceivably occur if there were two instances of the reconciliation job running post-restore (something \#79222 fixes). Release note: None --- First two commits are from #79139 and #79222 respectively. Co-authored-by: David Taylor <tinystatemachine@gmail.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: none.