backupccl: run TestFullClusterBackup with span configs#79228
backupccl: run TestFullClusterBackup with span configs#79228craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
Release note: none.
|
This change is |
b6d01e1 to
49968a1
Compare
arulajmani
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @adityamaru, @ajwerner, @dt, and @irfansharif)
pkg/ccl/backupccl/full_cluster_backup_restore_test.go, line 61 at r3 (raw file):
}, GCJob: &sql.GCJobTestingKnobs{ DisableNewProtectedTimestampSubsystemCheck: true,
driveby: You should be able to remove this as well now. We should also get rid of the knob entirely, considering this was the only use.
49968a1 to
02cd2e5
Compare
irfansharif
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/backupccl/full_cluster_backup_restore_test.go, line 61 at r3 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
driveby: You should be able to remove this as well now. We should also get rid of the knob entirely, considering this was the only use.
Done.
02cd2e5 to
9245adf
Compare
Fixes cockroachdb#70173. When restoring a cluster, we don't want to end up with two instances of the singleton reconciliation job. Release note: None
Closes cockroachdb#75060; speculating that the previous commit fixed the underlying issue. Previously the reconciliation job errored out with "expected to delete 11 row(s), deleted 10", which could conceivably occur if there were two instances of the reconciliation job running post-restore. Release note: None
9245adf to
f475361
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
Closes #75060; speculating that #79222 fixed the underlying issue.
Previously the reconciliation job errored out with "expected to delete
11 row(s), deleted 10", which could conceivably occur if there were two
instances of the reconciliation job running post-restore (something
#79222 fixes).
Release note: None
First two commits are from #79139 and #79222 respectively.