catalog: protobuf and cluster versioning for table statistics forecasts#79025
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 31, 2022
Merged
catalog: protobuf and cluster versioning for table statistics forecasts#79025craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Collaborator
Author
|
(Note that the first commit is #79009 which can be ignored.) |
msirek
reviewed
Mar 30, 2022
Contributor
msirek
left a comment
There was a problem hiding this comment.
Looks good to me. I'll leave it to the experts to approve it though.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ajwerner, @postamar, and @rytaft)
Add a field to the TableDescriptor for per-table statistics forecasting. We'll want this when backporting statistics forecasts to 22.1. Release note: None
63cbb77 to
9f1d234
Compare
mgartner
approved these changes
Mar 30, 2022
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status:
ajwerner
approved these changes
Mar 31, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewable status:
rytaft
approved these changes
Mar 31, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Thanks!
bors r+
Reviewed all commit messages.
Reviewable status:
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
michae2
added a commit
to michae2/cockroach
that referenced
this pull request
Aug 27, 2022
Add a new storage parameter (a.k.a. table setting) which can be used to override cluster setting `sql.stats.forecasts.enabled`. This builds on work done earlier in cockroachdb#79025 and cockroachdb#86932 so we don't have to do much, just wire it all together. Fixes: cockroachdb#86353 Release justification: Low-risk update to new functionality. Release note (sql change): Add a new table setting `sql_stats_forecasts_enabled` which controls whether statistics forecasts are generated for a specific table. When set, this overrides cluster setting `sql.stats.forecasts.enabled`.
michae2
added a commit
to michae2/cockroach
that referenced
this pull request
Aug 28, 2022
Add a new storage parameter (a.k.a. table setting) which can be used to override cluster setting `sql.stats.forecasts.enabled`. This builds on work done earlier in cockroachdb#79025 and cockroachdb#86932 so we don't have to do much, just wire it all together. Fixes: cockroachdb#86353 Release justification: Low-risk update to new functionality. Release note (sql change): Add a new table setting `sql_stats_forecasts_enabled` which controls whether statistics forecasts are generated for a specific table. When set, this overrides cluster setting `sql.stats.forecasts.enabled`.
craig bot
pushed a commit
that referenced
this pull request
Aug 28, 2022
86986: sql/stats: add table setting to disable generation of stats forecasts r=rytaft,msirek a=michae2 Add a new storage parameter (a.k.a. table setting) which can be used to override cluster setting `sql.stats.forecasts.enabled`. This builds on work done earlier in #79025 and #86932 so we don't have to do much, just wire it all together. Fixes: #86353 Release justification: Low-risk update to new functionality. Release note (sql change): Add a new table setting `sql_stats_forecasts_enabled` which controls whether statistics forecasts are generated for a specific table. When set, this overrides cluster setting `sql.stats.forecasts.enabled`. Co-authored-by: Michael Erickson <michae2@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a field to the TableDescriptor for per-table statistics forecasting.
We'll want this when backporting statistics forecasts to 22.1.
Release note: None