sql/stats: add table setting to disable generation of stats forecasts#86986
sql/stats: add table setting to disable generation of stats forecasts#86986craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Add a new cluster setting `sql.stats.forecasts.enabled` that can be used to disable generation of statistics forecasts in the stats cache. Changing this setting will cause the stats cache to gradually evict and reload all cached statistics as they are requested. Fixes: cockroachdb#86350 Release justification: Low-risk update to new functionality. Release note (sql change): Add a new cluster setting `sql.stats.forecasts.enabled` which controls whether statistics forecasts are generated by default for all tables. (Note that this is different from the session setting `optimizer_use_forecasts` which controls whether statistics forecasts are used when optimizing the current query. If forecasting is disabled, then even if `optimizer_use_forecasts` is true for a given query it won't have any forecasts to use.)
|
This change is |
|
Note that the first commit is from #86932 and can be ignored. |
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @msirek)
pkg/sql/opt/exec/execbuilder/testdata/forecast line 743 at r2 (raw file):
statement ok CREATE TABLE d (d DATE PRIMARY KEY) WITH (sql_stats_automatic_collection_enabled = false, sql_stats_forecasts_enabled = false)
Is it worth also testing the other direction, that we can explicitly enable stats on a table even if the cluster setting is false?
|
Previously, rytaft (Rebecca Taft) wrote…
(by stats I mean forecasts) |
msirek
left a comment
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Add a new storage parameter (a.k.a. table setting) which can be used to override cluster setting `sql.stats.forecasts.enabled`. This builds on work done earlier in cockroachdb#79025 and cockroachdb#86932 so we don't have to do much, just wire it all together. Fixes: cockroachdb#86353 Release justification: Low-risk update to new functionality. Release note (sql change): Add a new table setting `sql_stats_forecasts_enabled` which controls whether statistics forecasts are generated for a specific table. When set, this overrides cluster setting `sql.stats.forecasts.enabled`.
michae2
left a comment
There was a problem hiding this comment.
Thank you for the Saturday reviews!
bors r=rytaft,msirek
Reviewable status:
pkg/sql/opt/exec/execbuilder/testdata/forecast line 743 at r2 (raw file):
Previously, rytaft (Rebecca Taft) wrote…
(by stats I mean forecasts)
Yes, definitely worth testing, and good news is that I did sneakily include a test like this by adding sql_stats_forecasts_enabled = true to CREATE TABLE c up above. But that was too subtle, so I've moved it to an ALTER TABLE c down below with a comment.
|
Build succeeded: |
Add a new storage parameter (a.k.a. table setting) which can be used to
override cluster setting
sql.stats.forecasts.enabled. This builds onwork done earlier in #79025 and #86932 so we don't have to do much, just
wire it all together.
Fixes: #86353
Release justification: Low-risk update to new functionality.
Release note (sql change): Add a new table setting
sql_stats_forecasts_enabledwhich controls whether statisticsforecasts are generated for a specific table. When set, this overrides
cluster setting
sql.stats.forecasts.enabled.