catalog: protobuf and cluster versioning for autostats table settings#79009
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 30, 2022
Merged
catalog: protobuf and cluster versioning for autostats table settings#79009craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
ajwerner
approved these changes
Mar 30, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
The bazel flake on this PR was juicy. I got sniped: #79015.
I'm cool with this change. Thanks for going through the iterations on the details of using the fields.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @postamar)
rytaft
approved these changes
Mar 30, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Do you want to add the backport-22.1 label?
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:
This commit adds protobuf and cluster versioning needed for cockroachdb#78110 Release note: none
50e7857 to
2c6fc9c
Compare
Collaborator
|
While we're at it, can we preallocate another table descriptor field? 😬 #79025 |
msirek
commented
Mar 30, 2022
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds protobuf and cluster versioning needed for #78110
Release note: none