Skip to content

util/log: fix lying comment#47761

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:logic.fatal
Apr 22, 2020
Merged

util/log: fix lying comment#47761
craig[bot] merged 1 commit intocockroachdb:masterfrom
andreimatei:logic.fatal

Conversation

@andreimatei
Copy link
Copy Markdown
Contributor

SetExitFunc() claimed that a nil function was a way to reset it. It
wasn't; it'd lead to a crash.

Release note: None

SetExitFunc() claimed that a nil function was a way to reset it. It
wasn't; it'd lead to a crash.

Release note: None
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@andreimatei andreimatei requested a review from knz April 21, 2020 16:43
Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Copy Markdown
Contributor Author

@andreimatei andreimatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 21, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 21, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 21, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 21, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 21, 2020

Build failed

@knz
Copy link
Copy Markdown
Contributor

knz commented Apr 22, 2020

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Apr 22, 2020

Build succeeded

@craig craig bot merged commit 332b5a9 into cockroachdb:master Apr 22, 2020
@andreimatei andreimatei deleted the logic.fatal branch April 24, 2020 18:59
knz added a commit to knz/cockroach that referenced this pull request Jun 8, 2020
There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None
craig bot pushed a commit that referenced this pull request Jun 8, 2020
49887: sql: populate spatial_ref_sys table with projection entries r=sumeerbhola a=otan

Also fixed a bug where `\0` didn't actually output a NULL terminator (no
idea why it worked).

Release note (sql change): Populate the spatial_ref_sys table with
support SRID entries for geospatial data types.

49917: Makefile: make PROJ compile on Publish Bleeding Edge r=petermattis a=otan

As docgen relies on builtins which relies on proj, we are stuck in a
situation in cross compilation where we are trying to install docgen
with a non-native libproj.a file causing the linker to fail in `Upload
Binaries`. Fix this by not compiling docgen on cross compilations.

Also fix the windows compilation as PROJ will dump it into a
libproj_4_9.a instead of libproj.a.

Also make execgen not depend on LIBPROJ since it's not required.

Release note: None



49920: geo: move TestClipRectByEWKT test to geoindex r=sumeerbhola a=otan

Trying to make the geo package not depend on GEOS, and this is one of
the required steps.

Release note: None

49923: opt: incorporate operator volatility r=RaduBerinde a=RaduBerinde

Incorporate volatility of operators (unary, binary, comparison) into the
VolatilitySet property.

Unfortunately, this modifies most plans as pretty much everything is
"immutable". Perhaps once this work is behind us we will want to hide this
information from plans in most cases.

Release note: None

49956: scripts/release-notes: fix the error encountered on #47761 r=rmloveland a=knz

Fixes #49952

There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None

49963: lint: fix a linter message r=andreimatei a=andreimatei

A message had an unescaped format and ended up rendered like:
use YourFuncf("descriptive prefix %!s(MISSING)", ...)

Release note: None

Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Andrei Matei <andrei@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants