Skip to content

sql: populate spatial_ref_sys table with projection entries#49887

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:spatial_ref_sys
Jun 8, 2020
Merged

sql: populate spatial_ref_sys table with projection entries#49887
craig[bot] merged 1 commit intocockroachdb:masterfrom
otan-cockroach:spatial_ref_sys

Conversation

@otan
Copy link
Copy Markdown
Contributor

@otan otan commented Jun 4, 2020

Also fixed a bug where \0 didn't actually output a NULL terminator (no
idea why it worked).

Release note (sql change): Populate the spatial_ref_sys table with
support SRID entries for geospatial data types.

@otan otan requested review from a team and sumeerbhola June 4, 2020 22:46
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Also fixed a bug where `\0` didn't actually output a NULL terminator (no
idea why it worked).

Release note (sql change): Populate the spatial_ref_sys table with
support SRID entries for geospatial data types.
@otan otan force-pushed the spatial_ref_sys branch from bb804d9 to 2949573 Compare June 5, 2020 15:07
Copy link
Copy Markdown
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Canceled

@otan
Copy link
Copy Markdown
Contributor Author

otan commented Jun 8, 2020

bors r=sumeerbhola

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants