Skip to content

scripts/release-notes: fix the error encountered on #47761#49956

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20200608-rn
Jun 8, 2020
Merged

scripts/release-notes: fix the error encountered on #47761#49956
craig[bot] merged 1 commit intocockroachdb:masterfrom
knz:20200608-rn

Conversation

@knz
Copy link
Copy Markdown
Contributor

@knz knz commented Jun 8, 2020

Fixes #49952

There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None

@knz knz requested review from a team and rmloveland June 8, 2020 14:07
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

There's at lease one PR with a missing branch tips in refs/pull.
This commit makes the script tolerant of that failure.

Release note: None
Copy link
Copy Markdown
Collaborator

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!1! Thanks for investigating this, Raphael!

@knz
Copy link
Copy Markdown
Contributor Author

knz commented Jun 8, 2020

bors r=rmloveland

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Merge conflict (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 8, 2020

Build succeeded

@craig craig bot merged commit 15c11df into cockroachdb:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts: release notes script fails with "'refs/pull/origin/47761' did not resolve to an object"

3 participants