kv: truncate RangeFeed span to range descriptor #29219
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 28, 2018
Merged
kv: truncate RangeFeed span to range descriptor #29219craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Release note: None
Member
|
This change is |
danhhz
reviewed
Aug 28, 2018
Contributor
danhhz
left a comment
There was a problem hiding this comment.
RSpan().AsRawSpanWithNoLocals() stuff
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/ccl/changefeedccl/changefeed_test.go, line 383 at r2 (raw file):
func TestChangefeedTruncateRenameDrop(t *testing.T) { defer leaktest.AfterTest(t)() t.Skip("here")
debugging?
These seemed to get stuck without this. Release note: None
7a5e56a to
1056bdc
Compare
nvb
commented
Aug 28, 2018
Contributor
Author
nvb
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/ccl/changefeedccl/changefeed_test.go, line 383 at r2 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
debugging?
Woops, removed! Thanks for catching that.
craig bot
pushed a commit
that referenced
this pull request
Aug 28, 2018
29135: opt: directive that asserts a rule was used r=justinj a=justinj Brought up in #29050 as a possibility to avoid the case of certain rules no longer applying. Kind of a strawman right now because I'm not sure * if this is the syntax we want, * how widely we want to use it, I've just added it to one file for the purposes of this PR. I think this is probably valuable in that it asserts we're testing what we want to test, but I do think it's a little invasive as far as cluttering up the test directives goes. Open to suggestions for how to possibly improve. Release note: None 29219: kv: truncate RangeFeed span to range descriptor r=nvanbenschoten a=nvanbenschoten Small fix for RangeFeed's interaction with DistSender. Co-authored-by: Justin Jaffray <justin@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2018
29500: release-2.1: backport 7 rangefeed PRs r=nvanbenschoten a=nvanbenschoten Backport: * 5/5 commits from "kv: give Transport a haircut" (#28855) * 1/1 commits from "engine: use Txn.Timestamp instead of OrigTimestamp for LogLogicalOp" (#28970) * 1/1 commits from "rangefeed: add release valve to logical op consumption" (#29076) * 3/3 commits from "kv: teach DistSender about RangeFeeds, use for changefeeds" (#28912) * 1/1 commits from "rangefeed: small perf-related changes" (#29134) * 2/2 commits from "kv: truncate RangeFeed span to range descriptor " (#29219) * 2/2 commits from "storage: hook closed timestamps into rangefeed" (#28974) Please see individual PRs for details. All cherry-picks were clean. /cc @cockroachdb/release Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for RangeFeed's interaction with DistSender.