kv: give Transport a haircut#28855
Merged
craig[bot] merged 5 commits intocockroachdb:masterfrom Aug 21, 2018
Merged
Conversation
Member
|
This change is |
dce9daf to
6dcb123
Compare
tbg
approved these changes
Aug 21, 2018
Member
tbg
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 5 of 5 files at r5.
Reviewable status:complete! 1 of 0 LGTMs obtained
6dcb123 to
c85ce0f
Compare
Release note: None
These aren't needed anymore. Release note: None
This no longer needs to be thread-safe. Release note: None
This state is already in ReplicaDescriptor. Release note: None
This was not needed anymore. This should provide a small but real perf win because we can avoid the context.WithCancel call for every RPC. Release note: None
c85ce0f to
e9fd30c
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 21, 2018
28855: kv: give Transport a haircut r=nvanbenschoten a=nvanbenschoten This includes 5 refactors to `kv.Transport` that will make it a lot easier to extend for RangeFeed changes. They should also provide modest perf benefits due to reduced locking and allocation avoidance. The changes include: - adding `BatchRequest` to `Transport.SendNext` instead of capturing in `Transport` - ripping out `Transport.GetPending` and `batchClient.pending` - ripping out `clientPendingMu` from `grpcTransport` - removing `nodeID` from `batchClient` - ripping out `Transport.Close` No need to review yet. Pushing for CI. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2018
29500: release-2.1: backport 7 rangefeed PRs r=nvanbenschoten a=nvanbenschoten Backport: * 5/5 commits from "kv: give Transport a haircut" (#28855) * 1/1 commits from "engine: use Txn.Timestamp instead of OrigTimestamp for LogLogicalOp" (#28970) * 1/1 commits from "rangefeed: add release valve to logical op consumption" (#29076) * 3/3 commits from "kv: teach DistSender about RangeFeeds, use for changefeeds" (#28912) * 1/1 commits from "rangefeed: small perf-related changes" (#29134) * 2/2 commits from "kv: truncate RangeFeed span to range descriptor " (#29219) * 2/2 commits from "storage: hook closed timestamps into rangefeed" (#28974) Please see individual PRs for details. All cherry-picks were clean. /cc @cockroachdb/release Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes 5 refactors to
kv.Transportthat will make it a lot easier to extend for RangeFeed changes. They should also provide modest perf benefits due to reduced locking and allocation avoidance. The changes include:BatchRequesttoTransport.SendNextinstead of capturing inTransportTransport.GetPendingandbatchClient.pendingclientPendingMufromgrpcTransportnodeIDfrombatchClientTransport.CloseNo need to review yet. Pushing for CI.