rangefeed: small perf-related changes#29134
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 27, 2018
Merged
Conversation
This PR includes two small perf tweak that came up which running cdc/w=100/nodes=3/init=true. Release note: None
Member
|
This change is |
tbg
approved these changes
Aug 27, 2018
danhhz
reviewed
Aug 27, 2018
Contributor
danhhz
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
pkg/storage/rangefeed/processor.go, line 40 at r1 (raw file):
// defaultCheckStreamsInterval is the default interval at which a Processor // will check all streams to make sure they have not been canceled. defaultCheckStreamsInterval = 1 * time.Second
maybe note in the comment why this got bumped up
nvb
commented
Aug 27, 2018
Contributor
Author
nvb
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/storage/rangefeed/processor.go, line 40 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
maybe note in the comment why this got bumped up
Gave this a shot but nothing seemed very useful to document and keep around. The reason boils down to "I saw this come up as a blip on a profile and realized it was unnecessarily low".
Contributor
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
Aug 27, 2018
28721: sql: fix two bugs with TRUNCATE r=vivekmenezes a=vivekmenezes sql: correctly resolve schema mutations during TRUNCATE related to #27687 sql: mark schema change job as successful when table DROP/TRUNCATE The job is modified in the same transaction as the user's DROP/TRUNCATE transaction. 29134: rangefeed: small perf-related changes r=nvanbenschoten a=nvanbenschoten This PR includes two small perf tweak that came up which running cdc/w=100/nodes=3/init=true. Release note: None Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Sep 4, 2018
29500: release-2.1: backport 7 rangefeed PRs r=nvanbenschoten a=nvanbenschoten Backport: * 5/5 commits from "kv: give Transport a haircut" (#28855) * 1/1 commits from "engine: use Txn.Timestamp instead of OrigTimestamp for LogLogicalOp" (#28970) * 1/1 commits from "rangefeed: add release valve to logical op consumption" (#29076) * 3/3 commits from "kv: teach DistSender about RangeFeeds, use for changefeeds" (#28912) * 1/1 commits from "rangefeed: small perf-related changes" (#29134) * 2/2 commits from "kv: truncate RangeFeed span to range descriptor " (#29219) * 2/2 commits from "storage: hook closed timestamps into rangefeed" (#28974) Please see individual PRs for details. All cherry-picks were clean. /cc @cockroachdb/release Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two small perf tweak that came up
which running cdc/w=100/nodes=3/init=true.
Release note: None