storage: Deflake TestReplicaLease#25781
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 21, 2018
Merged
Conversation
This introduction of proactive lease renewals (cockroachdb#25322) made this test flaky in two ways. First, the test was (oddly) creating two Replica objects for range 1 on the same store (since cockroachdb#2996), leading to races when combined with the background lease renewal thread. Second, the test expects leases to expire so it needs to disable automatic renewals. Fixes cockroachdb#25748 Release note: None
Member
|
This change is |
Member
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Contributor
Author
|
bors r=tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
May 21, 2018
25781: storage: Deflake TestReplicaLease r=tschottdorf a=bdarnell This introduction of proactive lease renewals (#25322) made this test flaky in two ways. First, the test was (oddly) creating two Replica objects for range 1 on the same store (since #2996), leading to races when combined with the background lease renewal thread. Second, the test expects leases to expire so it needs to disable automatic renewals. Fixes #25748 Release note: None Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 30, 2018
29296: backport-2.0: Fix test flakes caused by automatic lease renewal r=a-robinson a=a-robinson Backport: * 1/1 commits from "storage: Adding testing knob to disable automatic lease renewals" (#25625) * 1/1 commits from "storage: Fix flaky TestReplicaNotLeaseHolderError" (#25676) * 1/1 commits from "storage: Deflake TestReplicaLease" (#25781) Please see individual PRs for details. /cc @cockroachdb/release Fixes #29189. The flakiness was introduced to the 2.0 branch by #28931. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduction of proactive lease renewals (#25322) made this test
flaky in two ways. First, the test was (oddly) creating two Replica
objects for range 1 on the same store (since #2996), leading to races
when combined with the background lease renewal thread. Second, the
test expects leases to expire so it needs to disable automatic
renewals.
Fixes #25748
Release note: None