storage: Fix flaky TestReplicaNotLeaseHolderError#25676
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 23, 2018
Merged
storage: Fix flaky TestReplicaNotLeaseHolderError#25676craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
tbg
approved these changes
May 19, 2018
Contributor
Author
|
bors r+ |
Contributor
Build failed |
Member
|
DrainTransferWithExtension failed :( |
Caused by the proactive renewal of expiration-based leases (see cockroachdb#25322 and cockroachdb#25625 for more detail). Fixes cockroachdb#25672 Release note: None
83ec2fd to
9706c03
Compare
Contributor
Author
That failure is very odd. It looks like nothing ever happened because node liveness heartbeats kept timing out. I'm not sure it's worth looking into unless it happens again, which it doesn't appear to have in teamcity lately. |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 23, 2018
25676: storage: Fix flaky TestReplicaNotLeaseHolderError r=a-robinson a=a-robinson Caused by the proactive renewal of expiration-based leases (see #25322 and #25625 for more detail). Fixes #25731 Release note: None I'm not sure how many more of these flakes to expect over the next couple weeks. I'm currently running `stressrace` on all of `pkg/storage` on a gceworker to try and ferret them out if there are any more, but there's no guarantee that'll find all of them. 25816: ui: don't show login indicator unless login is enabled r=couchand a=couchand In #25005 I accidentally let the login indicator leak even if the environment variable wasn't set. This corrects that issue. Release note: None Fixes: #25843 25853: dep: Bump grpc-go to include perf improvements and data race fix r=a-robinson a=a-robinson Un-reverts #24883 to include grpc/grpc-go#2074 This also removed hdrhistogram-writer because it apparently isn't used anymore. Release note: None Maybe we want to wait until they put this into a more formal release SHA, though. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
Contributor
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 30, 2018
29296: backport-2.0: Fix test flakes caused by automatic lease renewal r=a-robinson a=a-robinson Backport: * 1/1 commits from "storage: Adding testing knob to disable automatic lease renewals" (#25625) * 1/1 commits from "storage: Fix flaky TestReplicaNotLeaseHolderError" (#25676) * 1/1 commits from "storage: Deflake TestReplicaLease" (#25781) Please see individual PRs for details. /cc @cockroachdb/release Fixes #29189. The flakiness was introduced to the 2.0 branch by #28931. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by the proactive renewal of expiration-based leases (see #25322
and #25625 for more detail).
Fixes #25731
Release note: None
I'm not sure how many more of these flakes to expect over the next couple weeks. I'm currently running
stressraceon all ofpkg/storageon a gceworker to try and ferret them out if there are any more, but there's no guarantee that'll find all of them.