storage: Adding testing knob to disable automatic lease renewals#25625
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 17, 2018
Merged
storage: Adding testing knob to disable automatic lease renewals#25625craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
Contributor
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Contributor
Author
|
bors r+ |
Contributor
Merge conflict (retrying...) |
Contributor
Author
|
bors r+ |
In order to fix the test flakes caused by automatic lease renewals Fixes cockroachdb#25537 Fixes cockroachdb#25540 Fixes cockroachdb#25573 Fixes cockroachdb#25576 Fixes cockroachdb#25589 Fixes cockroachdb#25594 Fixes cockroachdb#25599 Fixes cockroachdb#25605 Fixes cockroachdb#25620 Release note: None
Contributor
Canceled |
196bfd4 to
ca05fd1
Compare
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 17, 2018
24883: dep: Bump grpc-go version r=a-robinson a=a-robinson And pull in new packages -- in particular, the encoding/proto package isn't needed for compilation but is needed at runtime. Release note: None --------------------- We should wait to merge this until they've cut the 1.12 release tag so that we aren't just at an arbitrary commit in their git history but I'm sending out the PR now so that I (or whoever would have done this) don't have to deal with debugging the missing encoding/proto package when it comes time to merge this. As tested in #17370 (comment), this gives a 5-10% boost in whole-cluster throughput and improved tail latencies when run with a highly concurrent workload. It appears to have little performance effect for lower-concurrency workloads. 25410: sql: run schema changes after CREATE TABLE in txn r=vivekmenezes a=vivekmenezes Includes a commit from #25362 and should be reviewed after that change. 25612: util: fix `retry.WithMaxAttempts` context cancelled before run. r=windchan7 a=windchan7 If context gets cancelled right after `retry.WithMaxAttempts` runs, the function passed to it will never gets run. Now `retry.WithMaxAttempts` will at least run the function once otherwise an error will be returned. Making this change because there are places such as `show_cluster_setting.go` require the passed in function to be run at least once. Otherwise there will be seg fault. Fixes: #25600. Fixes: #25603. Fixes: #25570. Fixes: #25567. Fixes: #25566. Fixes: #25511. Fixes: #25485. Release note: None 25625: storage: Adding testing knob to disable automatic lease renewals r=a-robinson a=a-robinson In order to fix the test flakes caused by automatic lease renewals Fixes #25537 Fixes #25540 Fixes #25568 Fixes #25573 Fixes #25576 Fixes #25589 Fixes #25594 Fixes #25599 Fixes #25605 Fixes #25620 Release note: None Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Vivek Menezes <vivek@cockroachlabs.com> Co-authored-by: Victor Chen <victor@cockroachlabs.com>
Contributor
Build succeeded |
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this pull request
May 23, 2018
Caused by the proactive renewal of expiration-based leases (see cockroachdb#25322 and cockroachdb#25625 for more detail). Fixes cockroachdb#25672 Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 23, 2018
25676: storage: Fix flaky TestReplicaNotLeaseHolderError r=a-robinson a=a-robinson Caused by the proactive renewal of expiration-based leases (see #25322 and #25625 for more detail). Fixes #25731 Release note: None I'm not sure how many more of these flakes to expect over the next couple weeks. I'm currently running `stressrace` on all of `pkg/storage` on a gceworker to try and ferret them out if there are any more, but there's no guarantee that'll find all of them. 25816: ui: don't show login indicator unless login is enabled r=couchand a=couchand In #25005 I accidentally let the login indicator leak even if the environment variable wasn't set. This corrects that issue. Release note: None Fixes: #25843 25853: dep: Bump grpc-go to include perf improvements and data race fix r=a-robinson a=a-robinson Un-reverts #24883 to include grpc/grpc-go#2074 This also removed hdrhistogram-writer because it apparently isn't used anymore. Release note: None Maybe we want to wait until they put this into a more formal release SHA, though. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Andrew Couch <andrew@cockroachlabs.com>
a-robinson
added a commit
to a-robinson/cockroach
that referenced
this pull request
Aug 29, 2018
Caused by the proactive renewal of expiration-based leases (see cockroachdb#25322 and cockroachdb#25625 for more detail). Fixes cockroachdb#25672 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Aug 30, 2018
29296: backport-2.0: Fix test flakes caused by automatic lease renewal r=a-robinson a=a-robinson Backport: * 1/1 commits from "storage: Adding testing knob to disable automatic lease renewals" (#25625) * 1/1 commits from "storage: Fix flaky TestReplicaNotLeaseHolderError" (#25676) * 1/1 commits from "storage: Deflake TestReplicaLease" (#25781) Please see individual PRs for details. /cc @cockroachdb/release Fixes #29189. The flakiness was introduced to the 2.0 branch by #28931. Co-authored-by: Alex Robinson <alexdwanerobinson@gmail.com> Co-authored-by: Ben Darnell <ben@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to fix the test flakes caused by automatic lease renewals
Fixes #25537
Fixes #25540
Fixes #25538
Fixes #25568
Fixes #25573
Fixes #25576
Fixes #25589
Fixes #25594
Fixes #25599
Fixes #25605
Fixes #25620
Release note: None